From: dave.martin@linaro.org (Dave Martin)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 0/2] ARM: assembler: Add uniform assembler framework
Date: Thu, 1 Mar 2012 13:20:41 +0000 [thread overview]
Message-ID: <20120301132041.GB2040@linaro.org> (raw)
In-Reply-To: <20120301130051.GE7363@n2100.arm.linux.org.uk>
On Thu, Mar 01, 2012 at 01:00:51PM +0000, Russell King - ARM Linux wrote:
> On Thu, Mar 01, 2012 at 11:49:42AM +0000, Dave Martin wrote:
> > Are you still interested in this series?
> >
> > I have a workaround for the above now, but it's not pretty -- I seem to
> > have opened a can of worms here.
> >
> >
> > We would need something like
> >
> > #define EXTENDED_ASM(stuff) asm ( ".include \"macros.inc\"\n\t" stuff )
> > #define EXTENDED_VASM(stuff) asm volatile ( ".include \"macros.inc\"\n\t" stuff )
> >
> > ...where macros.inc includes some logic to protect against multiple
> > inclusion.
> >
> > This would avoid problems caused by reordering done by the compiler.
> >
> > I think this can work, but it may be a step too far...
>
> I'm fairly tempted to say: "if it ain't broke, don't fix". AFAIK no one
> has reported problems here, so lets not hastily try to fix something that
> will error out if it does go wrong.
OK -- I'll shelve this series for now and we'll see if we can come up
with something more localised for the kvm/Xen case.
unified.h may work for now, but I don't want to add anything more along
those lines for unless it's definitely correct to do so...
Cheers
---Dave
next prev parent reply other threads:[~2012-03-01 13:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-28 18:59 [RFC PATCH 0/2] ARM: assembler: Add uniform assembler framework Dave Martin
2012-02-28 18:59 ` [RFC PATCH 1/2] " Dave Martin
2012-02-28 18:59 ` [RFC PATCH 2/2] ARM: virt: Add assembler helpers for the Virtualization Extensions Dave Martin
2012-02-28 19:24 ` [RFC PATCH 0/2] ARM: assembler: Add uniform assembler framework Russell King - ARM Linux
2012-02-28 19:44 ` Dave Martin
2012-02-29 19:28 ` Dave Martin
2012-03-01 11:49 ` Dave Martin
2012-03-01 13:00 ` Russell King - ARM Linux
2012-03-01 13:20 ` Dave Martin [this message]
2012-03-02 21:42 ` Nicolas Pitre
2012-03-02 21:40 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120301132041.GB2040@linaro.org \
--to=dave.martin@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).