From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 8/8] ARM: tegra: HACK: remove set_irq_flags() from driver
Date: Thu, 1 Mar 2012 20:54:08 +0000 [thread overview]
Message-ID: <20120301205408.GB19274@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CACRpkdZK+9gF7N2akyWw=tvcBS2X2FmSd2-SiNKiuRgUCYXx7w@mail.gmail.com>
On Thu, Mar 01, 2012 at 09:33:03PM +0100, Linus Walleij wrote:
> On Thu, Mar 1, 2012 at 8:26 PM, Alan Ott <alan@signal11.us> wrote:
>
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > The driver should not call set_irq_flags itself, and
> > cannot do this from a loadable module.
> >
> > Remove the call for now, which might break the driver
> > but at least lets the kernel link again.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> > ?drivers/usb/host/ehci-tegra.c | ? ?1 -
> > ?1 files changed, 0 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c
> > index dbc7fe8..ab91f26 100644
> > --- a/drivers/usb/host/ehci-tegra.c
> > +++ b/drivers/usb/host/ehci-tegra.c
> > @@ -729,7 +729,6 @@ static int tegra_ehci_probe(struct platform_device *pdev)
> > ? ? ? ? ? ? ? ?err = -ENODEV;
> > ? ? ? ? ? ? ? ?goto fail;
> > ? ? ? ?}
> > - ? ? ? set_irq_flags(irq, IRQF_VALID);
>
> The kernel is full of this kind of stuff (drivers/mfd/twl4030-irq.c):
>
> #ifdef CONFIG_ARM
> /* ARM requires an extra step to clear IRQ_NOREQUEST, which it
> * sets on behalf of every irq_chip. Also sets IRQ_NOPROBE.
> */
> set_irq_flags(irq, IRQF_VALID);
> #else
> /* same effect on other architectures */
> irq_set_noprobe(irq);
> #endif
>
> Can't we try to fix this for real instead of breaking the universe,
> hehe :-)
That depends whether you want 0..NR_IRQS to all be request-able before
they've been setup with their irq chips and handlers etc.
Unfortunately, genirq doesn't provide a standard helper to clear
IRQ_NOREQUEST, and that's why this pain persists.
next prev parent reply other threads:[~2012-03-01 20:54 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 19:26 [PATCH 0/8] ARM: Tegra: cleanup patches from Arnd Bergmann Alan Ott
2012-03-01 19:26 ` [PATCH 1/8] ARM: tegra: export tegra_gpio_{en,dis}able Alan Ott
2012-03-01 19:59 ` Olof Johansson
2012-03-02 7:24 ` Grant Likely
2012-03-01 19:26 ` [PATCH 2/8] ARM: tegra: do not hide dma declarations Alan Ott
2012-03-01 19:26 ` [PATCH 3/8] ARM: tegra: select CPU_FREQ_TABLE Alan Ott
2012-03-01 20:05 ` Olof Johansson
2012-03-01 19:26 ` [PATCH 4/8] ARM: tegra: build localtimer support only when needed Alan Ott
2012-03-02 11:40 ` Sergei Shtylyov
2012-03-01 19:26 ` [PATCH 5/8] ARM: tegra: work around tegra THUMB2_KERNEL bug Alan Ott
2012-03-01 20:02 ` Stephen Warren
2012-03-01 20:42 ` Russell King - ARM Linux
2012-03-01 20:46 ` Arnd Bergmann
2012-03-01 19:26 ` [PATCH 6/8] ARM: tegra: USB_ULPI needs USB Alan Ott
2012-03-01 20:05 ` Stephen Warren
2012-03-01 20:25 ` Arnd Bergmann
2012-03-01 20:36 ` Stephen Warren
2012-03-01 20:42 ` Arnd Bergmann
2012-03-01 19:26 ` [PATCH 7/8] ARM: tegra: export usb phy symbols Alan Ott
2012-03-01 20:14 ` Stephen Warren
2012-03-01 19:26 ` [PATCH 8/8] ARM: tegra: HACK: remove set_irq_flags() from driver Alan Ott
2012-03-01 19:36 ` Greg Kroah-Hartman
2012-03-01 20:12 ` Arnd Bergmann
2012-03-01 20:29 ` Stephen Warren
2012-03-01 20:38 ` Arnd Bergmann
2012-03-01 21:00 ` Russell King - ARM Linux
2012-03-01 20:33 ` Linus Walleij
2012-03-01 20:40 ` Arnd Bergmann
2012-03-01 20:54 ` Russell King - ARM Linux [this message]
2012-03-01 20:19 ` [PATCH 0/8] ARM: Tegra: cleanup patches from Arnd Bergmann Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120301205408.GB19274@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).