From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/3] ARM: OMAP1: ams-delta: set up regulator over modem reset GPIO pin
Date: Mon, 5 Mar 2012 11:27:43 -0800 [thread overview]
Message-ID: <20120305192742.GK12083@atomide.com> (raw)
In-Reply-To: <1330963512-20413-2-git-send-email-jkrzyszt@tis.icnet.pl>
* Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> [120305 07:35]:
> The Amstrad Delta on-board latch2 bit named MODEM_NRESET, now available
> as a GPIO pin AMS_DELTA_GPIO_PIN_NMODEM_RESET, is used to power up/down
> (bring into/out of a reset state) two distinct on-board devices
> simultaneously: the modem, and the voice codec. As a consequence, that
> bit is, or can be, manipulated concurrently by two drivers, or their
> platform provided hooks.
>
> Instead of updating those drivers to use the gpiolib API as a new method
> of controlling the MODEM_NRESET pin state, like it was done to other
> drivers accessing latch2 pins, and still being vulnerable to potential
> concurrency conflicts, or trying to solve that sharing issue with a
> custom piece of code, set up a fixed regulator device on top of that
> GPIO pin, with the intention of updating both drivers to manipulate that
> regulator, not the GPIO pin directly.
>
> Before the ASoC driver is updated and the modem platform data expanded
> with a power management callback for switching its power, the
> ams_delta_latch_write() function, which still provides the old API for
> accessing latch2 functionality from not updated drivers, is modified to
> toggle the regulator instead of the MODEM_NRESET GPIO pin. A helper
> function provided for balancing the regulator enable/disable operations,
> together with the consumer data needed for tracking the regulator state,
> will be removed once the drivers are updated.
>
> Depends on patch series "ARM: OMAP1: ams-delta: replace custom I/O with
> GPIO".
>
> Signed-off-by: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
> ---
> v2 -> v3 changes:
> * fix section mismatch isue.
>
> Changes against initial version:
> * rename consumer setup elements to match their final, modem only
> related purpose,
> * initialize the regulator pointer and mutex before first use, then
> omit testing that pointer against NULL value
Thanks, applying all three into ams-delta branch.
Regards,
Tony
next prev parent reply other threads:[~2012-03-05 19:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 16:05 [PATCH v3 0/3] Amstrad Delta: access MODEM_RESET GPIO pin over a regulator Janusz Krzysztofik
2012-03-05 16:05 ` [PATCH v3 1/3] ARM: OMAP1: ams-delta: set up regulator over modem reset GPIO pin Janusz Krzysztofik
2012-03-05 19:27 ` Tony Lindgren [this message]
2012-03-05 16:05 ` [PATCH v3 2/3] ARM: OMAP1: ams-delta: update the modem to use regulator API Janusz Krzysztofik
2012-03-05 16:05 ` [PATCH v3 3/3] ASoC: OMAP: ams-delta: drop .set_bias_level callback Janusz Krzysztofik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120305192742.GK12083@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).