From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2+: voltage: ensure voltage used is exact voltage from OPP table
Date: Tue, 6 Mar 2012 00:12:35 -0600 [thread overview]
Message-ID: <20120306061233.GC5670@kobold> (raw)
In-Reply-To: <877gyyor28.fsf@ti.com>
On 10:12-20120305, Kevin Hilman wrote:
> Tero Kristo <t-kristo@ti.com> writes:
>
> > On Fri, 2012-03-02 at 14:42 -0800, Kevin Hilman wrote:
> >> When using the SMPS regulators to scale voltages, the regulator
> >> framework may pass a minimum voltage that is not an exact OPP voltage.
> >> For the VC/VP controlled voltage domains, we must ensure that the
> >> voltage requested is the exact voltage from the OPP table. This is
> >> especially critical when using SR.
> >>
> >> To fix, voltdm_scale() uses the target voltage passed to walk through
> >> the OPP voltages until it finds a voltage that is >= one of the OPP
> >> voltages.
> >
> > I have just one question to this, how about smartreflex class1p5? Do we
> > have any plans for that one? The old implementation at least was using
> > voltdm_scale, so if we modify this function, smartreflex class1p5
> > doesn't work anymore.
>
> Since it's not in mainline, that is not my concern at the moment. We
> can worry about SR1.5 when I someone is motivated to push it upstream.
>
> > Otherwise this patch looks good to me.
Other than the minor misgiving of having to re-verify the voltage on
every scale, I am OK with it as well.
That said, I don't see why this should break class 1.5/3.5 support.
--
Regards,
Nishanth Menon
prev parent reply other threads:[~2012-03-06 6:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 22:42 [PATCH] ARM: OMAP2+: voltage: ensure voltage used is exact voltage from OPP table Kevin Hilman
2012-03-05 9:41 ` Tero Kristo
2012-03-05 18:12 ` Kevin Hilman
2012-03-06 6:12 ` Nishanth Menon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120306061233.GC5670@kobold \
--to=nm@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).