From: mad_soft@inbox.ru (Dmitry Artamonow)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH/RFC 2/2] arm/tegra: add timeout to PCIe PLL lock detection loop
Date: Tue, 6 Mar 2012 15:19:51 +0400 [thread overview]
Message-ID: <20120306111951.GA8494@rainbow> (raw)
In-Reply-To: <CANndwHav6JcqNOuOXcD1dSNUmVYAV=MJ+y+ud6202q6Dh42Vgw@mail.gmail.com>
On 10:38 Tue 06 Mar , Andi wrote:
> Hi,
>
> On Tue, Mar 6, 2012 at 9:45 AM, Dmitry Artamonow <mad_soft@inbox.ru> wrote:
> > ? ? ? ?/* Wait for the PLL to lock */
> > + ? ? ? timeout = 2000;
> > ? ? ? ?do {
> > ? ? ? ? ? ? ? ?val = pads_readl(PADS_PLL_CTL);
> > + ? ? ? ? ? ? ? mdelay(1);
>
> why are you using an mdelay? If you need to sleep 1ms just use
> usleep_range or similar
This driver uses mdelay(1) in other places, so I just used it for the sake
of consistency. And as this code runs just one time on boot, there's not
really much harm in doing delay with busy loop instead of sleeping.
Anyway, I agree that sleeping is better than busy waiting in general, so
I can respin this patch using usleep_range, or else prepare incremental
patch on top of this, which will change all mdelay in driver to usleep_range.
--
Best regards,
Dmitry "MAD" Artamonow
next prev parent reply other threads:[~2012-03-06 11:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 8:45 [PATCH/RFC 0/2] Couple of Tegra2 PCIe fixes(?) Dmitry Artamonow
2012-03-06 8:45 ` [PATCH/RFC 1/2] arm/tegra: fix harmony pinmux for PCIe Dmitry Artamonow
2012-03-06 16:55 ` Stephen Warren
2012-03-06 8:45 ` [PATCH/RFC 2/2] arm/tegra: add timeout to PCIe PLL lock detection loop Dmitry Artamonow
2012-03-06 9:38 ` Andi
2012-03-06 11:19 ` Dmitry Artamonow [this message]
2012-03-06 16:58 ` Stephen Warren
2012-03-06 19:09 ` Thierry Reding
2012-03-06 20:15 ` Dmitry Artamonow
2012-03-09 10:09 ` [PATCH v2 " Dmitry Artamonow
2012-03-12 18:09 ` Stephen Warren
2012-03-12 19:30 ` Dmitry Artamonow
2012-03-12 19:56 ` Olof Johansson
2012-03-13 5:46 ` [PATCH] arm/tegra: pcie: fix return value of function Dmitry Artamonow
2012-03-13 19:36 ` Stephen Warren
2012-03-18 17:27 ` Olof Johansson
2012-03-07 6:38 ` [PATCH/RFC 2/2] arm/tegra: add timeout to PCIe PLL lock detection loop Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120306111951.GA8494@rainbow \
--to=mad_soft@inbox.ru \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).