From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/6] ARM: mm: truncate memory banks to fit in 4GB space for classic MMU
Date: Tue, 6 Mar 2012 20:17:52 +0000 [thread overview]
Message-ID: <20120306201752.GA18151@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <alpine.LFD.2.02.1203061448540.31242@xanadu.home>
Hi Nicolas,
On Tue, Mar 06, 2012 at 07:49:43PM +0000, Nicolas Pitre wrote:
> On Tue, 6 Mar 2012, Will Deacon wrote:
> > On Tue, Mar 06, 2012 at 06:06:40PM +0000, Sergei Shtylyov wrote:
> > > On 03/06/2012 07:54 PM, Will Deacon wrote:
> > >
> > > > +#ifndef CONFIG_LPAE
> > > > + if (bank->start + size< bank->start) {
> > > > + printk(KERN_CRIT "Truncating memory at 0x%08llx to fit in "
> > > > + "32-bit physical address space\n", (long long)start);
> > > > + size = ULONG_MAX - bank->start;
> > >
> > > I think you forgot to add one here.
> >
> > No, I deliberately omit the last page because otherwise we end up with the
> > end address of the bank being calculated as 0, which leads to boot failure.
>
> What this mentioned in the code, or at least in the patch log?
Good idea - I'll add a comment to the code when we assign size.
Will
prev parent reply other threads:[~2012-03-06 20:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 16:54 [PATCH 0/6] Miscellaneous nommu fixes Will Deacon
2012-03-06 16:54 ` [PATCH 1/6] ARM: ptrace: fix ptrace_read_user for !CONFIG_MMU platforms Will Deacon
2012-03-06 16:54 ` [PATCH 2/6] kexec: crash: don't save swapper_pg_dir for !CONFIG_MMU configurations Will Deacon
2012-03-06 16:54 ` [PATCH 3/6] ARM: nommu: fix typo in mm/Kconfig Will Deacon
2012-03-06 16:54 ` [PATCH 4/6] ARM: suspend: fix CPU suspend code for !CONFIG_MMU configurations Will Deacon
2012-03-06 16:54 ` [PATCH 5/6] ARM: nommu: Use VECTORS_BASE for vector copying with !MMU Will Deacon
2012-03-06 16:54 ` [PATCH 6/6] ARM: mm: truncate memory banks to fit in 4GB space for classic MMU Will Deacon
2012-03-06 18:06 ` Sergei Shtylyov
2012-03-06 17:58 ` Will Deacon
2012-03-06 19:49 ` Nicolas Pitre
2012-03-06 20:17 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120306201752.GA18151@mudshark.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).