* [PATCH] gpio/omap: Fix section warning for omap_mpuio_alloc_gc()
@ 2012-03-06 21:26 Tony Lindgren
2012-03-06 23:55 ` Kevin Hilman
0 siblings, 1 reply; 3+ messages in thread
From: Tony Lindgren @ 2012-03-06 21:26 UTC (permalink / raw)
To: linux-arm-kernel
From: Tony Lindgren <tony@atomide.com>
Date: Mon, 5 Mar 2012 15:32:38 -0800
Subject: [PATCH] gpio/omap: Fix section warning for omap_mpuio_alloc_gc()
Make omap_mpuio_alloc_gc() __devinit as omap_gpio_chip_init()
is __devinit. Otherwise we get:
WARNING: vmlinux.o(.devinit.text+0xa10): Section mismatch in reference
from the function omap_gpio_chip_init() to the function .init.text:omap_mpuio_alloc_gc()
The function __devinit omap_gpio_chip_init() references
a function __init omap_mpuio_alloc_gc().
If omap_mpuio_alloc_gc is only used by omap_gpio_chip_init then
annotate omap_mpuio_alloc_gc with a matching annotation.
Signed-off-by: Tony Lindgren <tony@atomide.com>
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -1081,7 +1081,7 @@ static void omap_gpio_mod_init(struct gpio_bank *bank, int id)
}
}
-static __init void
+static __devinit void
omap_mpuio_alloc_gc(struct gpio_bank *bank, unsigned int irq_start,
unsigned int num)
{
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] gpio/omap: Fix section warning for omap_mpuio_alloc_gc()
2012-03-06 21:26 [PATCH] gpio/omap: Fix section warning for omap_mpuio_alloc_gc() Tony Lindgren
@ 2012-03-06 23:55 ` Kevin Hilman
2012-03-12 17:45 ` Grant Likely
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Hilman @ 2012-03-06 23:55 UTC (permalink / raw)
To: linux-arm-kernel
Tony Lindgren <tony@atomide.com> writes:
> From: Tony Lindgren <tony@atomide.com>
> Date: Mon, 5 Mar 2012 15:32:38 -0800
> Subject: [PATCH] gpio/omap: Fix section warning for omap_mpuio_alloc_gc()
>
> Make omap_mpuio_alloc_gc() __devinit as omap_gpio_chip_init()
> is __devinit. Otherwise we get:
>
> WARNING: vmlinux.o(.devinit.text+0xa10): Section mismatch in reference
> from the function omap_gpio_chip_init() to the function .init.text:omap_mpuio_alloc_gc()
> The function __devinit omap_gpio_chip_init() references
> a function __init omap_mpuio_alloc_gc().
> If omap_mpuio_alloc_gc is only used by omap_gpio_chip_init then
> annotate omap_mpuio_alloc_gc with a matching annotation.
>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
Acked-by: Kevin Hilman <khilman@ti.com>
> --- a/drivers/gpio/gpio-omap.c
> +++ b/drivers/gpio/gpio-omap.c
> @@ -1081,7 +1081,7 @@ static void omap_gpio_mod_init(struct gpio_bank *bank, int id)
> }
> }
>
> -static __init void
> +static __devinit void
> omap_mpuio_alloc_gc(struct gpio_bank *bank, unsigned int irq_start,
> unsigned int num)
> {
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] gpio/omap: Fix section warning for omap_mpuio_alloc_gc()
2012-03-06 23:55 ` Kevin Hilman
@ 2012-03-12 17:45 ` Grant Likely
0 siblings, 0 replies; 3+ messages in thread
From: Grant Likely @ 2012-03-12 17:45 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 06 Mar 2012 15:55:47 -0800, Kevin Hilman <khilman@ti.com> wrote:
> Tony Lindgren <tony@atomide.com> writes:
>
> > From: Tony Lindgren <tony@atomide.com>
> > Date: Mon, 5 Mar 2012 15:32:38 -0800
> > Subject: [PATCH] gpio/omap: Fix section warning for omap_mpuio_alloc_gc()
> >
> > Make omap_mpuio_alloc_gc() __devinit as omap_gpio_chip_init()
> > is __devinit. Otherwise we get:
> >
> > WARNING: vmlinux.o(.devinit.text+0xa10): Section mismatch in reference
> > from the function omap_gpio_chip_init() to the function .init.text:omap_mpuio_alloc_gc()
> > The function __devinit omap_gpio_chip_init() references
> > a function __init omap_mpuio_alloc_gc().
> > If omap_mpuio_alloc_gc is only used by omap_gpio_chip_init then
> > annotate omap_mpuio_alloc_gc with a matching annotation.
> >
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
>
> Acked-by: Kevin Hilman <khilman@ti.com>
applied, thx.
g.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-03-12 17:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-06 21:26 [PATCH] gpio/omap: Fix section warning for omap_mpuio_alloc_gc() Tony Lindgren
2012-03-06 23:55 ` Kevin Hilman
2012-03-12 17:45 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).