* [PATCH] ARM: OMAP2+: Fix build issues with missing include of linux/bug.h
@ 2012-03-07 21:32 Tony Lindgren
2012-03-08 0:45 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: Tony Lindgren @ 2012-03-07 21:32 UTC (permalink / raw)
To: linux-arm-kernel
Otherwise we can get the following for some .config files:
arch/arm/mach-omap2/powerdomain-common.c:
In function 'omap2_pwrdm_get_mem_bank_onstate_mask':
arch/arm/mach-omap2/powerdomain-common.c:64:3: error:
implicit declaration of function 'WARN_ON' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
Looks like this is needed for some .config files with
current for-next
--- a/arch/arm/mach-omap2/clkt_clksel.c
+++ b/arch/arm/mach-omap2/clkt_clksel.c
@@ -43,6 +43,7 @@
#include <linux/errno.h>
#include <linux/clk.h>
#include <linux/io.h>
+#include <linux/bug.h>
#include <plat/clock.h>
--- a/arch/arm/mach-omap2/powerdomain-common.c
+++ b/arch/arm/mach-omap2/powerdomain-common.c
@@ -13,6 +13,7 @@
#include <linux/errno.h>
#include <linux/kernel.h>
+#include <linux/bug.h>
#include "pm.h"
#include "cm.h"
#include "cm-regbits-34xx.h"
--- a/arch/arm/mach-omap2/powerdomain2xxx_3xxx.c
+++ b/arch/arm/mach-omap2/powerdomain2xxx_3xxx.c
@@ -15,6 +15,7 @@
#include <linux/io.h>
#include <linux/errno.h>
#include <linux/delay.h>
+#include <linux/bug.h>
#include <plat/prcm.h>
--- a/arch/arm/mach-omap2/powerdomains3xxx_data.c
+++ b/arch/arm/mach-omap2/powerdomains3xxx_data.c
@@ -13,6 +13,7 @@
#include <linux/kernel.h>
#include <linux/init.h>
+#include <linux/bug.h>
#include <plat/cpu.h>
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] ARM: OMAP2+: Fix build issues with missing include of linux/bug.h
2012-03-07 21:32 [PATCH] ARM: OMAP2+: Fix build issues with missing include of linux/bug.h Tony Lindgren
@ 2012-03-08 0:45 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2012-03-08 0:45 UTC (permalink / raw)
To: linux-arm-kernel
* Tony Lindgren <tony@atomide.com> [120307 13:04]:
>
> Looks like this is needed for some .config files with
> current for-next
This is because of next/master commit 6c03438ed (kernel.h: doesn't
explicitly use bug.h, so don't include it). Will update the commit
message to say:
Otherwise we can get the following if bug.h is not included from kernel.h:
> arch/arm/mach-omap2/powerdomain-common.c:
> In function 'omap2_pwrdm_get_mem_bank_onstate_mask':
> arch/arm/mach-omap2/powerdomain-common.c:64:3: error:
> implicit declaration of function 'WARN_ON' [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> --- a/arch/arm/mach-omap2/clkt_clksel.c
> +++ b/arch/arm/mach-omap2/clkt_clksel.c
> @@ -43,6 +43,7 @@
> #include <linux/errno.h>
> #include <linux/clk.h>
> #include <linux/io.h>
> +#include <linux/bug.h>
>
> #include <plat/clock.h>
>
> --- a/arch/arm/mach-omap2/powerdomain-common.c
> +++ b/arch/arm/mach-omap2/powerdomain-common.c
> @@ -13,6 +13,7 @@
>
> #include <linux/errno.h>
> #include <linux/kernel.h>
> +#include <linux/bug.h>
> #include "pm.h"
> #include "cm.h"
> #include "cm-regbits-34xx.h"
> --- a/arch/arm/mach-omap2/powerdomain2xxx_3xxx.c
> +++ b/arch/arm/mach-omap2/powerdomain2xxx_3xxx.c
> @@ -15,6 +15,7 @@
> #include <linux/io.h>
> #include <linux/errno.h>
> #include <linux/delay.h>
> +#include <linux/bug.h>
>
> #include <plat/prcm.h>
>
> --- a/arch/arm/mach-omap2/powerdomains3xxx_data.c
> +++ b/arch/arm/mach-omap2/powerdomains3xxx_data.c
> @@ -13,6 +13,7 @@
>
> #include <linux/kernel.h>
> #include <linux/init.h>
> +#include <linux/bug.h>
>
> #include <plat/cpu.h>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-08 0:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-07 21:32 [PATCH] ARM: OMAP2+: Fix build issues with missing include of linux/bug.h Tony Lindgren
2012-03-08 0:45 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).