* [PATCH v2] ARM: OMAP2+: Fix build issues with missing include of linux/bug.h
@ 2012-03-08 1:28 Tony Lindgren
2012-03-08 1:31 ` Olof Johansson
0 siblings, 1 reply; 3+ messages in thread
From: Tony Lindgren @ 2012-03-08 1:28 UTC (permalink / raw)
To: linux-arm-kernel
Otherwise we can get the following if bug.h is not included from kernel.h:
arch/arm/mach-omap2/powerdomain-common.c:
In function 'omap2_pwrdm_get_mem_bank_onstate_mask':
arch/arm/mach-omap2/powerdomain-common.c:64:3: error:
implicit declaration of function 'WARN_ON' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
Signed-off-by: Tony Lindgren <tony@atomide.com>
diff --git a/arch/arm/mach-omap2/clkt_clksel.c b/arch/arm/mach-omap2/clkt_clksel.c
index e25364d..04d551b 100644
--- a/arch/arm/mach-omap2/clkt_clksel.c
+++ b/arch/arm/mach-omap2/clkt_clksel.c
@@ -43,6 +43,7 @@
#include <linux/errno.h>
#include <linux/clk.h>
#include <linux/io.h>
+#include <linux/bug.h>
#include <plat/clock.h>
diff --git a/arch/arm/mach-omap2/powerdomain-common.c b/arch/arm/mach-omap2/powerdomain-common.c
index f97afff..c0aeabf 100644
--- a/arch/arm/mach-omap2/powerdomain-common.c
+++ b/arch/arm/mach-omap2/powerdomain-common.c
@@ -13,6 +13,7 @@
#include <linux/errno.h>
#include <linux/kernel.h>
+#include <linux/bug.h>
#include "pm.h"
#include "cm.h"
#include "cm-regbits-34xx.h"
diff --git a/arch/arm/mach-omap2/powerdomain2xxx_3xxx.c b/arch/arm/mach-omap2/powerdomain2xxx_3xxx.c
index 6a17e4c..0f0a9f1 100644
--- a/arch/arm/mach-omap2/powerdomain2xxx_3xxx.c
+++ b/arch/arm/mach-omap2/powerdomain2xxx_3xxx.c
@@ -15,6 +15,7 @@
#include <linux/io.h>
#include <linux/errno.h>
#include <linux/delay.h>
+#include <linux/bug.h>
#include <plat/prcm.h>
diff --git a/arch/arm/mach-omap2/powerdomains3xxx_data.c b/arch/arm/mach-omap2/powerdomains3xxx_data.c
index 8ef26da..b7ea468 100644
--- a/arch/arm/mach-omap2/powerdomains3xxx_data.c
+++ b/arch/arm/mach-omap2/powerdomains3xxx_data.c
@@ -13,6 +13,7 @@
#include <linux/kernel.h>
#include <linux/init.h>
+#include <linux/bug.h>
#include <plat/cpu.h>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2] ARM: OMAP2+: Fix build issues with missing include of linux/bug.h
2012-03-08 1:28 [PATCH v2] ARM: OMAP2+: Fix build issues with missing include of linux/bug.h Tony Lindgren
@ 2012-03-08 1:31 ` Olof Johansson
2012-03-08 1:32 ` Tony Lindgren
0 siblings, 1 reply; 3+ messages in thread
From: Olof Johansson @ 2012-03-08 1:31 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Mar 7, 2012 at 5:28 PM, Tony Lindgren <tony@atomide.com> wrote:
> Otherwise we can get the following if bug.h is not included from kernel.h:
>
> arch/arm/mach-omap2/powerdomain-common.c:
> In function 'omap2_pwrdm_get_mem_bank_onstate_mask':
> arch/arm/mach-omap2/powerdomain-common.c:64:3: error:
> implicit declaration of function 'WARN_ON' [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
Applied to next/fixes-non-critical. Thanks!
-Olof
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] ARM: OMAP2+: Fix build issues with missing include of linux/bug.h
2012-03-08 1:31 ` Olof Johansson
@ 2012-03-08 1:32 ` Tony Lindgren
0 siblings, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2012-03-08 1:32 UTC (permalink / raw)
To: linux-arm-kernel
* Olof Johansson <olof@lixom.net> [120307 16:59]:
> On Wed, Mar 7, 2012 at 5:28 PM, Tony Lindgren <tony@atomide.com> wrote:
> > Otherwise we can get the following if bug.h is not included from kernel.h:
> >
> > arch/arm/mach-omap2/powerdomain-common.c:
> > In function 'omap2_pwrdm_get_mem_bank_onstate_mask':
> > arch/arm/mach-omap2/powerdomain-common.c:64:3: error:
> > implicit declaration of function 'WARN_ON' [-Werror=implicit-function-declaration]
> > cc1: some warnings being treated as errors
> >
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
>
> Applied to next/fixes-non-critical. Thanks!
Thanks a lot!
Tony
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-03-08 1:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-08 1:28 [PATCH v2] ARM: OMAP2+: Fix build issues with missing include of linux/bug.h Tony Lindgren
2012-03-08 1:31 ` Olof Johansson
2012-03-08 1:32 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).