linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2+: Fix compile error when FB_OMAP2 is not set
Date: Thu, 8 Mar 2012 12:46:07 -0800	[thread overview]
Message-ID: <20120308204607.GX12083@atomide.com> (raw)
In-Reply-To: <20120308204328.GW12083@atomide.com>

* Tony Lindgren <tony@atomide.com> [120308 12:11]:
> Otherwise we will get:
> 
> arch/arm/plat-omap/fb.c:101: error: expected ?)? before ?*? token
> 
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> 
> ---
> 
> Tomi, you need something like this for what you have in for-next.
> 
> --- a/arch/arm/plat-omap/fb.c
> +++ b/arch/arm/plat-omap/fb.c
> @@ -98,6 +98,8 @@ arch_initcall(omap_init_fb);
>  
>  #else
>  
> -void __init omapfb_set_lcd_config(omap_lcd_config *config) { }
> +void __init omapfb_set_lcd_config(const struct omap_lcd_config *config)
> +{
> +}
>  
>  #endif

Also now seeing the following with what you have in for-next:

drivers/video/omap2/displays/panel-taal.c: In function ?taal_num_errors_show?:
drivers/video/omap2/displays/panel-taal.c:605: warning: ?errors? may be used uninitialized in this function

Tony

  reply	other threads:[~2012-03-08 20:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-08 20:43 [PATCH] ARM: OMAP2+: Fix compile error when FB_OMAP2 is not set Tony Lindgren
2012-03-08 20:46 ` Tony Lindgren [this message]
2012-03-09  8:11   ` Tomi Valkeinen
2012-03-09 18:26     ` Tony Lindgren
2012-03-09  7:55 ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120308204607.GX12083@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).