From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: OMAP: WiLink platform data for the PandaBoard
Date: Fri, 9 Mar 2012 10:31:51 -0800 [thread overview]
Message-ID: <20120309183150.GH12083@atomide.com> (raw)
In-Reply-To: <1331074504-22683-1-git-send-email-mgherzan@gmail.com>
Hi Luca,
* Mircea Gherzan <mgherzan@gmail.com> [120306 14:23]:
> The "uim" deamon requires sysfs entries that are filled in using
> this platform data.
>
> Signed-off-by: Mircea Gherzan <mgherzan@gmail.com>
> ---
> arch/arm/mach-omap2/board-omap4panda.c | 14 ++++++++++++--
> include/linux/ti_wilink_st.h | 2 ++
> 2 files changed, 14 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-omap4panda.c b/arch/arm/mach-omap2/board-omap4panda.c
> index b1d74d6..339e781 100644
> --- a/arch/arm/mach-omap2/board-omap4panda.c
> +++ b/arch/arm/mach-omap2/board-omap4panda.c
> @@ -27,6 +27,7 @@
> #include <linux/i2c/twl.h>
> #include <linux/regulator/machine.h>
> #include <linux/regulator/fixed.h>
> +#include <linux/ti_wilink_st.h>
> #include <linux/wl12xx.h>
>
> #include <mach/hardware.h>
> @@ -56,12 +57,21 @@
> #define HDMI_GPIO_HPD 63 /* Hotplug detect */
>
> /* wl127x BT, FM, GPS connectivity chip */
> -static int wl1271_gpios[] = {46, -1, -1};
> +static struct ti_st_plat_data wilink_platform_data = {
> + .nshutdown_gpio = 46,
> + .dev_name = "/dev/ttyO1",
> + .flow_cntrl = 1,
> + .baud_rate = 3000000,
> + .chip_enable = NULL,
> + .suspend = NULL,
> + .resume = NULL,
> +};
> +
> static struct platform_device wl1271_device = {
> .name = "kim",
> .id = -1,
> .dev = {
> - .platform_data = &wl1271_gpios,
> + .platform_data = &wilink_platform_data,
> },
> };
>
> diff --git a/include/linux/ti_wilink_st.h b/include/linux/ti_wilink_st.h
> index 2ef4385..3ca0269 100644
> --- a/include/linux/ti_wilink_st.h
> +++ b/include/linux/ti_wilink_st.h
> @@ -25,6 +25,8 @@
> #ifndef TI_WILINK_ST_H
> #define TI_WILINK_ST_H
>
> +#include <linux/skbuff.h>
> +
> /**
> * enum proto-type - The protocol on WiLink chips which share a
> * common physical interface like UART.
> --
Just checking.. Can you please take a look at this patch
and confirm that this is how things are supposed to be done?
To me passing some third driver's dev_name in pdata seems
pretty weird.. But then again maybe I just don't know how
this is supposed to work.
Regards,
Tony
next prev parent reply other threads:[~2012-03-09 18:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 22:55 [PATCH v2] ARM: OMAP: WiLink platform data for the PandaBoard Mircea Gherzan
2012-03-09 18:31 ` Tony Lindgren [this message]
2012-03-10 5:07 ` Luciano Coelho
2012-03-11 20:05 ` Mircea Gherzan
2012-03-11 20:13 ` Pavan Savoy
2012-03-11 22:30 ` Mircea Gherzan
2012-03-17 12:57 ` Mircea Gherzan
2012-05-08 21:56 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120309183150.GH12083@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).