From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: kirkwood: Basic support for DNS-320 and DNS-325
Date: Mon, 12 Mar 2012 08:17:19 +0000 [thread overview]
Message-ID: <201203120817.19777.arnd@arndb.de> (raw)
In-Reply-To: <20120312030232.GX5050@titan.lakedaemon.net>
On Monday 12 March 2012, Jason Cooper wrote:
> > + dnskw_gpio_register(39, "dnskw:power:sata0", 1);
> > + dnskw_gpio_register(40, "dnskw:power:sata1", 1);
> > +
> > + /* Set NAS to turn back on after a power failure */
> > + dnskw_gpio_register(37, "dnskw:power:recover", 1);
> > +}
> > +
>
> I doubt this board is the only one that wants to be added while the
> conversion to devicetree is progressing. It makes more sense to me to
> break the above out to a separate file, eg board-dnskw.c. I'll follow
> and break out the dreamplug code to board-dreamplug.c. Otherwise, I see
> board-dt.c becoming a long mess.
>
> Arnd, sound okay to you?
Either way is fine with me. I personally wouldn't expect many more boards
to come in before the DT conversion has mostly completed, but I guess you
have a better feeling for what other hardware is out there that people
are interested in.
Arnd
next prev parent reply other threads:[~2012-03-12 8:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-11 14:33 [PATCH 0/2] Add support for DNS-320 and DNS-325 using devicetree Jamie Lentin
2012-03-11 14:33 ` [PATCH 1/2] ARM: kirkwood: Basic support for DNS-320 and DNS-325 Jamie Lentin
2012-03-11 17:46 ` Arnd Bergmann
2012-03-12 3:17 ` Jason Cooper
2012-03-12 8:11 ` Arnd Bergmann
2012-03-12 16:10 ` Jason Cooper
2012-03-12 3:02 ` Jason Cooper
2012-03-12 8:17 ` Arnd Bergmann [this message]
2012-03-12 14:22 ` Jamie Lentin
2012-03-12 14:27 ` Jason Cooper
2012-03-12 14:58 ` Arnd Bergmann
2012-03-12 17:59 ` Jamie Lentin
2012-03-12 18:56 ` Jason Cooper
2012-03-11 14:33 ` [PATCH 2/2] ARM: kirkwood: Convert orion-nand to fdt Jamie Lentin
2012-03-11 17:52 ` Arnd Bergmann
2012-03-12 3:23 ` Jason Cooper
2012-03-12 2:36 ` [PATCH 0/2] Add support for DNS-320 and DNS-325 using devicetree Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203120817.19777.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).