From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/2] ARM: Exynos: Add device tree support for interrupt combiner
Date: Mon, 12 Mar 2012 21:52:46 -0600 [thread overview]
Message-ID: <20120313035246.6BC8A3E07E4@localhost> (raw)
In-Reply-To: <1329798806-32482-3-git-send-email-thomas.abraham@linaro.org>
On Tue, 21 Feb 2012 10:03:26 +0530, Thomas Abraham <thomas.abraham@linaro.org> wrote:
> Add device tree based instantiation of the interrupt combiner controller.
>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Signed-off-by: Thomas Abraham <thomas.abraham@linaro.org>
> ---
> @@ -406,13 +432,33 @@ void __init combiner_init(void __iomem *combiner_base, struct device_node *np)
>
> for (i = 0; i < MAX_COMBINER_NR; i++) {
> combiner_init_one(i, combiner_base + (i >> 2) * 0x10);
> - combiner_cascade_irq(i, IRQ_SPI(i));
> +#ifdef CONFIG_OF
> + irq = np ? irq_of_parse_and_map(np, i) : IRQ_SPI(i);
> +#else
> + irq = IRQ_SPI(i);
> +#endif
Hmmm, the #ifdef is rather ugly. I'd rather have an empty
irq_of_parse_and_map() that always returns 0.
The patch series is fine, and you can add my acked-by, but please send
a follow-up patch to clean it up.
Acked-by: Grant Likely <grant.likely@secretlab.ca>
next prev parent reply other threads:[~2012-03-13 3:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-21 4:33 [PATCH v4 0/2] ARM: Exynos: Add irq_domain and device tree support for combiner Thomas Abraham
2012-02-21 4:33 ` [PATCH v4 1/2] ARM: Exynos: Add irq_domain support for interrupt combiner Thomas Abraham
2012-02-21 4:33 ` [PATCH v4 2/2] ARM: Exynos: Add device tree " Thomas Abraham
2012-03-13 3:52 ` Grant Likely [this message]
2012-03-13 6:46 ` Thomas Abraham
2012-03-12 21:07 ` [PATCH v4 0/2] ARM: Exynos: Add irq_domain and device tree support for combiner Thomas Abraham
2012-03-13 1:34 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120313035246.6BC8A3E07E4@localhost \
--to=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).