linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 09/11] ASoC: fsl: remove the fatal error checking on codec-handle
Date: Tue, 13 Mar 2012 23:46:39 +0000	[thread overview]
Message-ID: <20120313234638.GY3177@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4F5FD706.8040209@freescale.com>

On Tue, Mar 13, 2012 at 06:23:50PM -0500, Timur Tabi wrote:

> sound {
> 	compatible = "fsl,imx51-babbage-sgtl5000",
> 		     "fsl,imx-audio-sgtl5000";
> 	model = "imx51-babbage-sgtl5000";
> 	ssi-controller = <&ssi1>;
> 	audio-codec = <&sgtl5000>;
> 	mux-int-port = <1>;
> 	mux-ext-port = <3>;
> };

> How does this handle multiple SSIs, each connected to its own codec?

With this card those would just be separate CODECs.  This is a binding
for a simple card.

> And where's the binding for the DMA controller?

The DMA controller is transparently instantiated on Tegra systems, there
really isn't a meaningfully separate DMA controller - the I2S controller
specifies the signal to use.  Currently the card takes care of the ASoC
level driver stuff but it really should be done by the I2S controller.

> I honestly don't see how this is an improvement over what I came up with.

The biggest improvement is that the SoC binding knows nothing about the
card binding at all, cards are completely separate and are free to
define any binding they choose using any number of on-SoC and off-SoC
devices.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120313/db40adc5/attachment.sig>

  reply	other threads:[~2012-03-13 23:46 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-08 16:59 [PATCH v3 00/11] ASoC: add imx-sgtl5000 machine driver working with fsl_ssi Shawn Guo
2012-03-08 16:59 ` [PATCH v3 01/11] ASoC: core: missing set_fmt should not be complaint Shawn Guo
2012-03-08 18:24   ` Mark Brown
2012-03-08 16:59 ` [PATCH v3 02/11] ASoC: fsl: separate SSI and DMA Kconfig options Shawn Guo
2012-03-08 16:59 ` [PATCH v3 03/11] ASoC: imx: merge sound/soc/imx into sound/soc/fsl Shawn Guo
2012-03-08 16:59 ` [PATCH v3 04/11] ASoC: fsl: rename imx-pcm Kconfig options and filename Shawn Guo
2012-03-08 16:59 ` [PATCH v3 05/11] ASoC: fsl: create fsl_utils to accommodate the common functions Shawn Guo
2012-03-08 16:59 ` [PATCH v3 06/11] ASoC: fsl: remove helper fsl_asoc_get_codec_dev_name Shawn Guo
2012-03-08 16:59 ` [PATCH v3 07/11] ASoC: fsl: check property 'compatible' for the machine name Shawn Guo
2012-03-08 20:50   ` Timur Tabi
2012-03-09 11:51   ` Mark Brown
2012-03-08 16:59 ` [PATCH v3 08/11] ASoC: fsl: make fsl_ssi driver compilable on ARM/IMX Shawn Guo
2012-03-08 20:13   ` Timur Tabi
2012-03-09  1:26     ` Shawn Guo
2012-03-09  2:09       ` Tabi Timur-B04825
2012-03-09  3:21         ` Shawn Guo
2012-03-09  4:03           ` Tabi Timur-B04825
2012-03-09 11:53           ` Mark Brown
2012-03-08 16:59 ` [PATCH v3 09/11] ASoC: fsl: remove the fatal error checking on codec-handle Shawn Guo
2012-03-08 20:50   ` Timur Tabi
2012-03-09  1:32     ` Shawn Guo
2012-03-13 23:23       ` Timur Tabi
2012-03-13 23:46         ` Mark Brown [this message]
2012-03-14  2:57           ` Tabi Timur-B04825
2012-03-14 12:27             ` Mark Brown
2012-03-14 23:00               ` Timur Tabi
2012-03-15 13:02                 ` Shawn Guo
2012-03-15 13:37                   ` Tabi Timur-B04825
2012-03-15 14:21                     ` Shawn Guo
2012-03-15 15:39                       ` [alsa-devel] " Trent Piepho
2012-03-15 15:57                         ` Trent Piepho
2012-03-15 16:24                           ` Mark Brown
2012-03-15 16:47                       ` Timur Tabi
2012-03-16  1:27                         ` Shawn Guo
2012-03-16  1:55                           ` Tabi Timur-B04825
2012-03-17 21:42                             ` Mark Brown
2012-03-15 14:27                 ` Mark Brown
2012-03-15 14:34                   ` Shawn Guo
2012-03-15 16:44                   ` Timur Tabi
2012-03-15 17:11                     ` Mark Brown
2012-03-16  2:01                     ` Shawn Guo
2012-03-16  2:07                       ` Tabi Timur-B04825
2012-03-16  2:23                         ` Shawn Guo
2012-03-16  3:44                           ` Tabi Timur-B04825
2012-03-16  3:53                             ` Shawn Guo
2012-03-16  4:08                               ` Tabi Timur-B04825
2012-03-16  4:14                                 ` Shawn Guo
2012-03-16  4:17                                   ` Tabi Timur-B04825
2012-03-16  2:52                         ` Shawn Guo
2012-03-16  3:53                           ` Tabi Timur-B04825
2012-03-16  4:05                             ` Shawn Guo
2012-03-16 19:18                             ` Mark Brown
2012-03-09 11:55     ` Mark Brown
2012-03-08 16:59 ` [PATCH v3 10/11] ASoC: fsl: let fsl_ssi work with imx pcm and machine drivers Shawn Guo
2012-03-08 19:15   ` Sascha Hauer
2012-03-09  1:51     ` Shawn Guo
2012-03-08 20:45   ` Timur Tabi
2012-03-09  3:19     ` Shawn Guo
2012-03-09  4:02       ` Tabi Timur-B04825
2012-03-09  5:00         ` Shawn Guo
2012-03-08 16:59 ` [PATCH v3 11/11] ASoC: fsl: add imx-sgtl5000 machine driver Shawn Guo
2012-03-08 20:05 ` [PATCH v3 00/11] ASoC: add imx-sgtl5000 machine driver working with fsl_ssi Timur Tabi
2012-03-09  1:19   ` Shawn Guo
2012-03-09  2:11     ` Tabi Timur-B04825
2012-03-09  7:13       ` Shawn Guo
2012-03-09  7:28         ` Shawn Guo
2012-03-09 12:12           ` Mark Brown
2012-03-09 11:59         ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120313234638.GY3177@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).