From mboxrd@z Thu Jan 1 00:00:00 1970 From: broonie@opensource.wolfsonmicro.com (Mark Brown) Date: Wed, 14 Mar 2012 12:32:36 +0000 Subject: [PATCH] ARM: pxa: fix regulator related build fail in magician_defconfig In-Reply-To: <4F608F4F.8020106@windriver.com> References: <1331084814.11802.YahooMailClassic@web29012.mail.ird.yahoo.com> <1331242494-3157-1-git-send-email-paul.gortmaker@windriver.com> <4F608F4F.8020106@windriver.com> Message-ID: <20120314123236.GE3133@opensource.wolfsonmicro.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Mar 14, 2012 at 08:30:07AM -0400, Paul Gortmaker wrote: > On 12-03-14 04:38 AM, Haojian Zhuang wrote: > > How do you think about Mark's comments? Use dev_name() at here. > I'm not sure I quite understand you. I'd looked up the > structs and got their respective value that would be > returned by dev_name(), which is what I thought was > requested of me. Yes, that's what you should do. Calling dev_name() is only possible if you have the struct device and removing the need for the struct device is exactly what we're trying to avoid here. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: