linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/6] regmap: add support for 7_25 format
Date: Thu, 15 Mar 2012 10:44:44 +0000	[thread overview]
Message-ID: <20120315104443.GC3138@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1331757790-10583-2-git-send-email-marc@cpdesign.com.au>

On Thu, Mar 15, 2012 at 07:43:05AM +1100, Marc Reilly wrote:
> This adds support for devices with 7 address bits and 25 data bits.
> The initial intended user for this are the mc13xxx mfds in spi mode.
> (The 25th data bit is actually a dummy bit)
> 
> Signed-off-by: Marc Reilly <marc@cpdesign.com.au>

It looks like this should be using the pad_bits parameter, though
currently we only actually support pad bytes and integer sized register
values.  Ugh.  We also have some entertainment because this device
contains a touchscreen so I imagine you want readback but devices using
odd register sizes don't do readback right now.

What I think we want to do here is use pad_bits then internally to the
API notice that reg_bits + pad_bits is a byte and therefore set up for 8
bit registers and set a new value reg_shift in the map which shifts the
register address left, either teaching the register format functions
about it or just making a new one.  This should work better from a
framework point of view.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120315/5fbd7597/attachment.sig>

  reply	other threads:[~2012-03-15 10:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-14 20:43 mc13xxx: add I2C support (now with regmap), V3 Marc Reilly
2012-03-14 20:43 ` [PATCH v3 1/6] regmap: add support for 7_25 format Marc Reilly
2012-03-15 10:44   ` Mark Brown [this message]
2012-03-14 20:43 ` [PATCH v3 2/6] regmap: Add support for device with 24 data bits Marc Reilly
2012-03-15 10:46   ` Mark Brown
2012-03-14 20:43 ` [PATCH v3 3/6] mfd: mc13xxx-core: Prepare for separate spi and i2c backends Marc Reilly
2012-03-14 20:43 ` [PATCH v3 4/6] mfd: mc13xxx-core: use regmap for register access Marc Reilly
2012-03-15 17:43   ` Mark Brown
2012-03-14 20:43 ` [PATCH v3 5/6] mfd: mc13xxx-core: Move spi specific code into separate module Marc Reilly
2012-03-14 20:43 ` [PATCH v3 6/6] mfd: mc13xxx: Add i2c driver Marc Reilly
2012-03-14 22:15   ` Fabio Estevam
2012-03-15 13:40   ` Shubhrajyoti Datta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120315104443.GC3138@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).