From mboxrd@z Thu Jan 1 00:00:00 1970 From: s.hauer@pengutronix.de (Sascha Hauer) Date: Thu, 15 Mar 2012 16:00:48 +0100 Subject: [PATCH 1/2] ARM: imx6q: add pll round_rate support In-Reply-To: <20120315144601.GA5701@richard-laptop> References: <1331713379-8437-1-git-send-email-richard.zhao@linaro.org> <1331713379-8437-2-git-send-email-richard.zhao@linaro.org> <20120314085228.GM3852@pengutronix.de> <20120315144601.GA5701@richard-laptop> Message-ID: <20120315150048.GC3852@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Mar 15, 2012 at 10:46:04PM +0800, Richard Zhao wrote: > On Wed, Mar 14, 2012 at 09:52:28AM +0100, Sascha Hauer wrote: > > On Wed, Mar 14, 2012 at 04:22:58PM +0800, Richard Zhao wrote: > > > Signed-off-by: Richard Zhao > > > --- > > > > > > #define DEF_PLL(name) \ > > > static struct clk name = { \ > > > @@ -681,6 +741,7 @@ static int pll_set_rate(struct clk *clk, unsigned long rate) > > > .disable = pll_disable, \ > > > .get_rate = name##_get_rate, \ > > > .set_rate = name##_set_rate, \ > > > + .round_rate = name##_round_rate, \ > > > > I hope this ## stuff is gone soon with the generic clock framework. It > > is so ugly and inefficient. > I hope this doesn't prevent this two patches go in. Given that we are short from getting a generic clock framework (and I think this time it's for real) and that you are not mention in any words what these patches fix I don't see a reason for merging them. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |