From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] ARM: OMAP: fix missing __devexit_p() annotations
Date: Thu, 15 Mar 2012 09:59:33 -0700 [thread overview]
Message-ID: <20120315165932.GY12083@atomide.com> (raw)
In-Reply-To: <CAORVsuUVC4hpotK=eybA=Eqtfg0+PivjwRUENjCwcLG2dp1Ucg@mail.gmail.com>
* Jean Pihet <jean.pihet@newoldbits.com> [120315 04:09]:
> Russell,
>
> On Thu, Mar 15, 2012 at 11:30 AM, Russell King
> <rmk+kernel@arm.linux.org.uk> wrote:
> > Missing __devexit_p() annotations in driver structures for remove functions
> > marked with __devexit is waiting for build errors to happen, such as:
> >
> > `omap_system_dma_remove' referenced in section `.data' of arch/arm/plat-omap/bui
> > lt-in.o: defined in discarded section `.devexit.text' of arch/arm/plat-omap/buil
> > t-in.o
> >
> > Add the necessary annotation, and as a result of audit, fix others which
> > are also missing in arch/arm/*omap*.
> >
> > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> > Acked-by: Tony Lindgren <tony@atomide.com>
> > ---
> > ?arch/arm/mach-omap2/smartreflex.c | ? ?2 +-
> > ?arch/arm/plat-omap/dma.c ? ? ? ? ?| ? ?2 +-
> > ?2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c
> > index 7e755bb..47c77a1 100644
> > --- a/arch/arm/mach-omap2/smartreflex.c
> > +++ b/arch/arm/mach-omap2/smartreflex.c
> > @@ -1012,7 +1012,7 @@ static int __devexit omap_sr_remove(struct platform_device *pdev)
> > ?}
> >
> > ?static struct platform_driver smartreflex_driver = {
> > - ? ? ? .remove ? ? ? ? = omap_sr_remove,
> > + ? ? ? .remove ? ? ? ? = __devexit_p(omap_sr_remove),
> > ? ? ? ?.driver ? ? ? ? = {
> > ? ? ? ? ? ? ? ?.name ? = "smartreflex",
> > ? ? ? ?},
> Tony already has this change in his master branch, commit
> 149f1d5c8d2fd6879cdf93ca70f1cb745e698a1e ('ARM: OMAP2+: Fix devexit
> for smartreflex when CONFIG_HOTPLUG is not set').
Also same commit in arm-soc/for-next.
Regards,
Tony
next prev parent reply other threads:[~2012-03-15 16:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 10:28 Lost fixes? Russell King - ARM Linux
2012-03-15 10:30 ` [PATCH 4/6] ARM: OMAP: fix missing __devexit_p() annotations Russell King
2012-03-15 11:06 ` Jean Pihet
2012-03-15 16:59 ` Tony Lindgren [this message]
2012-03-15 10:30 ` [PATCH 5/6] ARM: OMAP2+: I2C: always compile I2C reset code, even if I2C driver is not built Paul Walmsley
2012-03-15 16:56 ` Tony Lindgren
2012-03-15 10:31 ` [PATCH 6/6] ARM: OMAP: fix cpufreq build Russell King
2012-03-15 17:10 ` Kevin Hilman
2012-03-15 18:47 ` Paul Walmsley
2012-03-26 8:32 ` Russell King - ARM Linux
2012-03-26 22:07 ` Kevin Hilman
2012-03-15 10:44 ` Lost fixes? Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120315165932.GY12083@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).