From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/4] drivers: input: Fix OMAP_GPIO_IRQ with gpio_to_irq() in ams_delta_serio_exit()
Date: Tue, 20 Mar 2012 09:52:46 -0700 [thread overview]
Message-ID: <20120320165246.GH9859@atomide.com> (raw)
In-Reply-To: <1332158817-26311-4-git-send-email-tarun.kanti@ti.com>
Hi Dmitry,
* Tarun Kanti DebBarma <tarun.kanti@ti.com> [120319 05:09]:
> Even though ams-delta-serio input driver uses gpio_to_irq() in all
> relevent places to get irq number, the ams_delta_serio_exit() still
> uses OMAP_GPIO_IRQ macro. Fix this.
>
> Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@ti.com>
Care to ack this one? I'd like to apply all four as fixes
at the end of the merge window so we can drop the old and
now broken OMAP_GPIO_IRQ macro.
Regards,
Tony
> ---
> drivers/input/serio/ams_delta_serio.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/input/serio/ams_delta_serio.c b/drivers/input/serio/ams_delta_serio.c
> index d4d08bd..dbe1ae8 100644
> --- a/drivers/input/serio/ams_delta_serio.c
> +++ b/drivers/input/serio/ams_delta_serio.c
> @@ -170,7 +170,7 @@ module_init(ams_delta_serio_init);
> static void __exit ams_delta_serio_exit(void)
> {
> serio_unregister_port(ams_delta_serio);
> - free_irq(OMAP_GPIO_IRQ(AMS_DELTA_GPIO_PIN_KEYBRD_CLK), 0);
> + free_irq(gpio_to_irq(AMS_DELTA_GPIO_PIN_KEYBRD_CLK), 0);
> gpio_free(AMS_DELTA_GPIO_PIN_KEYBRD_CLK);
> gpio_free(AMS_DELTA_GPIO_PIN_KEYBRD_DATA);
> }
> --
> 1.7.0.4
>
next prev parent reply other threads:[~2012-03-20 16:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 12:06 [PATCH v2 0/4] ARM: OMAP: boards: changes to support dynamic irq alloc Tarun Kanti DebBarma
2012-03-19 12:06 ` [PATCH v2 1/4] ARM: OMAP1: boards: Fix OMAP_GPIO_IRQ usage with gpio_to_irq() Tarun Kanti DebBarma
2012-03-29 4:58 ` Olof Johansson
2012-03-29 5:34 ` DebBarma, Tarun Kanti
2012-03-19 12:06 ` [PATCH v2 2/4] ARM: OMAP2+: " Tarun Kanti DebBarma
2012-03-19 12:06 ` [PATCH v2 3/4] drivers: input: Fix OMAP_GPIO_IRQ with gpio_to_irq() in ams_delta_serio_exit() Tarun Kanti DebBarma
2012-03-20 16:52 ` Tony Lindgren [this message]
2012-03-20 17:36 ` Dmitry Torokhov
2012-03-19 12:06 ` [PATCH v2 4/4] ARM: OMAP: Remove OMAP_GPIO_IRQ macro definition Tarun Kanti DebBarma
2012-03-19 12:17 ` [PATCH v2 0/4] ARM: OMAP: boards: changes to support dynamic irq alloc Shilimkar, Santosh
2012-03-19 12:30 ` DebBarma, Tarun Kanti
2012-03-19 19:17 ` Tony Lindgren
2012-03-19 22:58 ` Cousson, Benoit
2012-03-19 23:39 ` Tony Lindgren
2012-03-20 9:00 ` Cousson, Benoit
2012-03-20 10:59 ` DebBarma, Tarun Kanti
2012-03-20 16:51 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120320165246.GH9859@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).