From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/9] ARM: omap2/n8x0: work around modular omap mmc
Date: Sat, 24 Mar 2012 09:23:16 +0000 [thread overview]
Message-ID: <20120324092316.GA22608@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1332522836-29517-4-git-send-email-mathieu.poirier@linaro.org>
On Fri, Mar 23, 2012 at 11:13:50AM -0600, mathieu.poirier at linaro.org wrote:
> From: Russell King <linux@arm.linux.org.uk>
This is wrong. I am not the author of this patch.
> When the omap driver is built as a module for n8x0,
> n8x0_mmc_set_power_menelaus cannot call into the driver:
>
> arch/arm/mach-omap2/board-n8x0.c:374: undefined reference
> to `omap_mmc_notify_cover_event'
>
> As a workaround, do not provide that device in this case. This needs
> to be fixed properly, e.g. by converting n8x0 to be probed through the
> device tree and moving that code into the driver.
>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> Suggested-by: Russell King <linux@arm.linux.org.uk>
> Acked-by: Tony Lindgren <tony@atomide.com>
> ---
> arch/arm/mach-omap2/board-n8x0.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-n8x0.c b/arch/arm/mach-omap2/board-n8x0.c
> index 6722627..8529ca0 100644
> --- a/arch/arm/mach-omap2/board-n8x0.c
> +++ b/arch/arm/mach-omap2/board-n8x0.c
> @@ -193,8 +193,10 @@ static struct omap_onenand_platform_data board_onenand_data[] = {
> };
> #endif
>
> -#if defined(CONFIG_MENELAUS) && \
> - (defined(CONFIG_MMC_OMAP) || defined(CONFIG_MMC_OMAP_MODULE))
> +#ifdef CONFIG_MMC_OMAP_MODULE
> +#warning FIXME: cannot call omap_mmc_notify_cover_event for CONFIG_MMC_OMAP_MODULE
> +#endif
> +#if defined(CONFIG_MENELAUS) && (defined(CONFIG_MMC_OMAP)
>
> /*
> * On both N800 and N810, only the first of the two MMC controllers is in use.
> --
> 1.7.5.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2012-03-24 9:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-23 17:13 [PATCH 0/9] omap randconfig fixes for v3.3 mathieu.poirier at linaro.org
2012-03-23 17:13 ` [PATCH 1/9] arm/omap: enable building omap2 without omap2420/2430 mathieu.poirier at linaro.org
2012-03-23 17:13 ` [PATCH 2/9] omap: fix visibility of omap2_mbox_iva_priv mathieu.poirier at linaro.org
2012-03-23 18:30 ` Tony Lindgren
2012-03-23 17:13 ` [PATCH 3/9] ARM: omap2/n8x0: work around modular omap mmc mathieu.poirier at linaro.org
2012-03-23 17:29 ` Tony Lindgren
2012-03-24 9:23 ` Russell King - ARM Linux [this message]
2012-03-23 17:13 ` [PATCH 4/9] ARM: omap2+: fix building without i2c mathieu.poirier at linaro.org
2012-03-23 17:22 ` Tony Lindgren
2012-03-23 17:13 ` [PATCH 5/9] tty/serial/omap: console can only be built-in mathieu.poirier at linaro.org
2012-03-23 18:33 ` Tony Lindgren
2012-03-23 17:13 ` [PATCH 6/9] omap2: select twl4030 support on boards that need it mathieu.poirier at linaro.org
2012-03-23 17:13 ` [PATCH 7/9] omap2plus: ensure that one of omap2/3/4 is selected mathieu.poirier at linaro.org
2012-03-23 17:28 ` Tony Lindgren
2012-03-23 17:38 ` Arnd Bergmann
2012-03-23 18:14 ` Tony Lindgren
2012-03-23 17:13 ` [PATCH 8/9] arm: OMAP depends on MMU mathieu.poirier at linaro.org
2012-03-23 17:13 ` [PATCH 9/9] ARM: omap: select CPU_FREQ_TABLE where needed mathieu.poirier at linaro.org
2012-03-23 18:27 ` Tony Lindgren
2012-03-26 23:09 ` Kevin Hilman
2012-03-29 17:28 ` [PATCH 0/9] omap randconfig fixes for v3.3 Tony Lindgren
2012-05-07 19:07 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120324092316.GA22608@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).