linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: pxa: fix build failure for regulator consumer in em-x270.c
Date: Wed, 28 Mar 2012 16:39:18 +0100	[thread overview]
Message-ID: <20120328153918.GX3232@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAN1soZy7jB_H0meVyh_H8nmbaSDmiDpjBYi_WO=pmjYzEf9r6Q@mail.gmail.com>

On Wed, Mar 28, 2012 at 11:37:37PM +0800, Haojian Zhuang wrote:
> On Wed, Mar 28, 2012 at 11:27 PM, Mark Brown

> > These don't look like good fixes, you should be specifying the
> > dev_name() for the consumer device? ?Presumably it's two separate
> > consumers and should be .0 and .1 or something?

> Could you do a quick update on dev_name() according to Mark's comment?

> -REGULATOR_CONSUMER(ldo10, &pxa_device_mci.dev, "vcc sdio");
> +REGULAOTR_CONSUMER(ldo10, dev_name(&pxa_device_mci.dev), "vcc sdio");

No, you're missing the point again.  As I said previously the whole
point of this interface is that you don't have to have access to the
struct device.  This should be the string *returned* by dev_name(), not
a direct call to dev_name().
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120328/7ab84218/attachment.sig>

  reply	other threads:[~2012-03-28 15:39 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-05 23:12 [PATCH] ARM: pxa: fix build failure for regulator consumer in em-x270.c Paul Gortmaker
2012-03-06  8:46 ` Igor Grinberg
2012-03-06  9:12   ` Haojian Zhuang
2012-03-06 12:16     ` Mark Brown
2012-03-06 12:22       ` Haojian Zhuang
2012-03-07  0:10 ` Paul Gortmaker
2012-03-08 22:06   ` Paul Gortmaker
2012-03-28 15:21     ` Igor Grinberg
2012-03-28 15:27       ` Mark Brown
2012-03-28 15:37         ` Haojian Zhuang
2012-03-28 15:39           ` Mark Brown [this message]
2012-03-28 15:59         ` Paul Gortmaker
2012-03-28 16:13           ` Mark Brown
2012-03-28 16:59             ` Paul Gortmaker
2012-03-29 14:28               ` Igor Grinberg
2012-03-29 14:54                 ` Mark Brown
2012-03-29 14:57                   ` Paul Gortmaker
2012-03-29 15:11                     ` Mark Brown
2012-03-29 17:43                       ` [PATCH v3] " Paul Gortmaker
2012-03-30  0:41                         ` Haojian Zhuang
2012-03-30 12:24                         ` Igor Grinberg
2012-03-29 14:55                 ` [PATCH] " Paul Gortmaker
2012-03-30 11:25                   ` Igor Grinberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120328153918.GX3232@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).