From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Wed, 28 Mar 2012 10:03:17 -0700 Subject: [PATCH 05/12] Add dummy smsc911x regulators to cm-t35. In-Reply-To: <4F72B0D0.70703@compulab.co.il> References: <1332494504-10251-1-git-send-email-Russ.Dill@ti.com> <1332494504-10251-6-git-send-email-Russ.Dill@ti.com> <4F71E290.2050403@compulab.co.il> <20120327172819.GQ9859@atomide.com> <4F72B0D0.70703@compulab.co.il> Message-ID: <20120328170316.GR9859@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Igor Grinberg [120327 23:36]: > Hi Tony, > > On 03/27/12 19:28, Tony Lindgren wrote: > > * Igor Grinberg [120327 08:56]: > >> Hi Russ, > >> > >> This patch works, but can we, please use the attached patch instead? > > > > Hmm what's the difference here? Do you have some real controllable > > regulator for one of the smsc911x instances? > > Well, the difference here is that those regulators will only be present > if the smsc911x controllers are present and their initialization is done > along with the controllers. > Also, I want to separate the cm-t35 from sb-t35 for future easier > refactoring of the sb-t35 code so it can be reused also on cm-t3517. > > Only vddvario for smsc911x.0 is controllable - connected to VIO, but > VIO will never be disabled as it also controls many other devices > (DRAM is among them), so I prefer it to be dummy and keep it together > with vdd33a. OK thanks for the clarification. > > Anyways, I take it that you have tested that both smsc911x interfaces > > work now? > > Yes, both regulators are registered and found by the smsc911x driver. > There is some kind of problem with the smsc911x.1, but it looks unrelated > to the patch: OK good to hear. Regarding the following problem.. > smsc911x: Driver version 2008-10-21 > irq 323: nobody cared (try booting with the "irqpoll" option) > [] (unwind_backtrace+0x0/0xfc) from [] (__report_bad_irq+0x28/0xbc) > [] (__report_bad_irq+0x28/0xbc) from [] (note_interrupt+0x1e0/0x230) > [] (note_interrupt+0x1e0/0x230) from [] (handle_irq_event_percpu+0xb0/0x1a0) > [] (handle_irq_event_percpu+0xb0/0x1a0) from [] (handle_irq_event+0x3c/0x5c) > [] (handle_irq_event+0x3c/0x5c) from [] (handle_level_irq+0x90/0xfc) > [] (handle_level_irq+0x90/0xfc) from [] (generic_handle_irq+0x38/0x40) > [] (generic_handle_irq+0x38/0x40) from [] (gpio_irq_handler+0x1b0/0x20c) > [] (gpio_irq_handler+0x1b0/0x20c) from [] (generic_handle_irq+0x38/0x40) > [] (generic_handle_irq+0x38/0x40) from [] (handle_IRQ+0x38/0x84) > [] (handle_IRQ+0x38/0x84) from [] (omap3_intc_handle_irq+0x48/0x4c) > [] (omap3_intc_handle_irq+0x48/0x4c) from [] (__irq_svc+0x44/0x78) > Exception stack(0xcf02de20 to 0xcf02de68) > de20: cf02c018 cf02c000 00000000 cf02de58 60000013 c06739fc 00000143 c06739fc > de40: 60000013 00000508 c06739dc 00000000 00022d69 cf02de68 cf02b3c0 c04890fc > de60: 20000013 ffffffff > [] (__irq_svc+0x44/0x78) from [] (_raw_spin_unlock_irqrestore+0x64/0x68) > [] (_raw_spin_unlock_irqrestore+0x64/0x68) from [] (__setup_irq+0x1b4/0x3d4) > [] (__setup_irq+0x1b4/0x3d4) from [] (request_threaded_irq+0xdc/0x148) > [] (request_threaded_irq+0xdc/0x148) from [] (smsc911x_drv_probe+0x350/0x528) > [] (smsc911x_drv_probe+0x350/0x528) from [] (platform_drv_probe+0x18/0x1c) > [] (platform_drv_probe+0x18/0x1c) from [] (really_probe+0x64/0x160) > [] (really_probe+0x64/0x160) from [] (driver_probe_device+0x48/0x60) > [] (driver_probe_device+0x48/0x60) from [] (__driver_attach+0x94/0x98) > [] (__driver_attach+0x94/0x98) from [] (bus_for_each_dev+0x54/0x80) > [] (bus_for_each_dev+0x54/0x80) from [] (bus_add_driver+0xa8/0x2a4) > [] (bus_add_driver+0xa8/0x2a4) from [] (driver_register+0x78/0x184) > [] (driver_register+0x78/0x184) from [] (do_one_initcall+0x34/0x184) > [] (do_one_initcall+0x34/0x184) from [] (do_basic_setup+0x34/0x40) > [] (do_basic_setup+0x34/0x40) from [] (kernel_init+0x64/0xec) > [] (kernel_init+0x64/0xec) from [] (kernel_thread_exit+0x0/0x8) > handlers: > [] smsc911x_irqhandler > Disabling IRQ #323 > > I still haven't had a chance to look into this. > Does anyone have a clue? ..care to see if you have OMAP_GPIO_IRQ entry for your board? If so, we're still waiting for the cleanup-fixes branch to get merged that changes things to use gpio_to_irq() instead. Regards, Tony