public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: marc@cpdesign.com.au (Marc Reilly)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mfd: mc13xxx: add I2C support fix building for v3.4
Date: Thu, 29 Mar 2012 07:47:50 +1100	[thread overview]
Message-ID: <201203290747.50881.marc@cpdesign.com.au> (raw)
In-Reply-To: <1332943273-22447-1-git-send-email-alexg@meprolight.com>

Hi,

As Mark Brown already said, these changes should be squashed into a new 
version of the patches.

On Thursday, March 29, 2012 01:01:13 AM Alex Gershgorin wrote:
> This patch fixes the compilation errors after the patches
> from series mc13xxx-add-I2C-support-V4 were applied.
> 
> Signed-off-by: Alex Gershgorin <alexg@meprolight.com>
> ---
>  drivers/mfd/Kconfig        |    2 ++
>  drivers/mfd/mc13xxx-core.c |    2 +-
>  2 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index c3fbc5e..2119732 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -577,6 +577,8 @@ config MFD_MC13XXX
>  	depends on SPI_MASTER || I2C
>  	select MFD_CORE
>  	select MFD_MC13783
> +	select REGMAP_I2C if I2C
This can go under the "config MFD_MC13XXX_I2C" entry in patch 4/4 (the "if 
I2C" won't be needed)

> +	select REGMAP_SPI if SPI_MASTER
This can go under the "config MFD_MC13XXX_SPI" entry in patch 3/4


>  	help
>  	  Enable support for the Freescale MC13783 and MC13892 PMICs.
>  	  This driver provides common support for accessing the device,
> diff --git a/drivers/mfd/mc13xxx-core.c b/drivers/mfd/mc13xxx-core.c
> index 31dbf91..5a60273 100644
> --- a/drivers/mfd/mc13xxx-core.c
> +++ b/drivers/mfd/mc13xxx-core.c
> @@ -616,7 +616,7 @@ static int mc13xxx_add_subdevice(struct mc13xxx
> *mc13xxx, const char *format) #ifdef CONFIG_OF
>  static int mc13xxx_probe_flags_dt(struct mc13xxx *mc13xxx)
>  {
> -	struct device_node *np = mc13xxx->dev.of_node;
> +	struct device_node *np = mc13xxx->dev->of_node;

Good catch! This can be fixed up in 4/4

@Alex, you seen keen to do this, so I'll leave it to you :)
Otherwise, I'm happy to do it, just let me know.

Cheers,
Marc

  parent reply	other threads:[~2012-03-28 20:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-28 14:01 [PATCH] mfd: mc13xxx: add I2C support fix building for v3.4 Alex Gershgorin
2012-03-28 14:40 ` Mark Brown
2012-03-28 16:31   ` Alex Gershgorin
2012-03-28 16:35     ` Mark Brown
2012-03-28 17:38       ` Alex Gershgorin
2012-03-28 20:47 ` Marc Reilly [this message]
2012-03-29  7:51   ` Alex Gershgorin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201203290747.50881.marc@cpdesign.com.au \
    --to=marc@cpdesign.com.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox