From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 04/16] pwm: Add table-based lookup for static mappings
Date: Thu, 29 Mar 2012 23:03:42 +0100 [thread overview]
Message-ID: <20120329220342.GK4153@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1332945238-14897-5-git-send-email-thierry.reding@avionic-design.de>
On Wed, Mar 28, 2012 at 04:33:46PM +0200, Thierry Reding wrote:
> + static struct pwm_lookup board_pwm_lookup[] = {
> + PWM_LOOKUP("tegra-pwm", 0, "pwm-backlight"),
> + };
The clock and regulator APIs namespace the consumers by struct device -
might this not be sensible here? pwm_get() does already take the device
as an argument. It'd feel safer, and for example there's plenty of
phones out there with two backlit displays...
> + * pwm_get() - look up and request a PWM device
> + * @dev: device for PWM consumer
> + * @provider: name of provider PWM chip
> + * @index: per-chip index of PWM to request
The documentation is out of sync with the signature.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120329/afdf521d/attachment.sig>
next prev parent reply other threads:[~2012-03-29 22:03 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-28 14:33 [PATCH v5 00/16] Add PWM framework and device tree support Thierry Reding
2012-03-28 14:33 ` [PATCH v5 01/16] pwm: Add PWM framework support Thierry Reding
2012-03-29 21:41 ` Mark Brown
2012-04-04 6:36 ` Shawn Guo
2012-04-04 6:39 ` Thierry Reding
2012-03-28 14:33 ` [PATCH v5 02/16] pwm: Allow chips to support multiple PWMs Thierry Reding
2012-03-29 21:50 ` Mark Brown
2012-04-04 6:44 ` Shawn Guo
2012-03-28 14:33 ` [PATCH v5 03/16] pwm: Add debugfs interface Thierry Reding
2012-03-29 21:56 ` Mark Brown
2012-04-04 6:47 ` Shawn Guo
2012-03-28 14:33 ` [PATCH v5 04/16] pwm: Add table-based lookup for static mappings Thierry Reding
2012-03-29 22:03 ` Mark Brown [this message]
2012-03-30 5:06 ` Thierry Reding
2012-03-30 10:18 ` Mark Brown
2012-03-30 10:38 ` Thierry Reding
2012-03-31 14:30 ` Thierry Reding
2012-04-01 15:20 ` Shawn Guo
2012-04-02 0:47 ` Shawn Guo
2012-04-02 4:50 ` Thierry Reding
2012-03-28 14:33 ` [PATCH v5 05/16] pwm: Add device tree support Thierry Reding
2012-03-28 14:53 ` Arnd Bergmann
2012-03-29 21:47 ` Mark Brown
2012-03-30 6:24 ` Thierry Reding
2012-03-28 14:33 ` [PATCH v5 06/16] ARM: tegra: Fix PWM clock programming Thierry Reding
2012-03-28 14:33 ` [PATCH v5 07/16] ARM: tegra: Provide clock for only one PWM controller Thierry Reding
2012-03-28 14:33 ` [PATCH v5 08/16] pwm: Add NVIDIA Tegra SoC support Thierry Reding
2012-03-30 18:57 ` Stephen Warren
2012-04-04 6:54 ` Shawn Guo
2012-03-28 14:33 ` [PATCH v5 09/16] pwm: tegra: Add device tree support Thierry Reding
2012-03-30 19:00 ` Stephen Warren
2012-04-02 8:37 ` Thierry Reding
2012-04-02 15:42 ` Stephen Warren
2012-04-03 17:55 ` Thierry Reding
2012-04-03 19:43 ` Rob Herring
2012-04-03 23:42 ` Grant Likely
2012-04-04 5:00 ` Thierry Reding
2012-04-04 18:32 ` Stephen Warren
2012-04-07 1:44 ` Grant Likely
2012-03-28 14:33 ` [PATCH v5 10/16] pwm: Move Blackfin PWM driver to PWM framework Thierry Reding
2012-03-28 14:33 ` [PATCH v5 11/16] pwm: Move PXA " Thierry Reding
2012-03-28 14:33 ` [PATCH v5 12/16] ARM i.MX: Move i.MX pwm driver to pwm framework Thierry Reding
2012-03-28 14:33 ` [PATCH v5 13/16] ARM Samsung: Move s3c " Thierry Reding
2012-03-28 14:33 ` [PATCH v5 14/16] ARM vt8500: Move vt8500 " Thierry Reding
2012-03-28 14:33 ` [PATCH v5 15/16] pwm-backlight: Add rudimentary device tree support Thierry Reding
2012-03-30 19:04 ` Stephen Warren
2012-04-04 18:11 ` Thierry Reding
2012-03-28 14:33 ` [PATCH v5 16/16] pwm: Take over maintainership of the PWM subsystem Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120329220342.GK4153@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).