linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] regulator: rename function regulator_register_fixed
Date: Sat, 31 Mar 2012 11:25:08 +0100	[thread overview]
Message-ID: <20120331102507.GB3163@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1333182812-423-2-git-send-email-shawn.guo@linaro.org>

On Sat, Mar 31, 2012 at 04:33:32PM +0800, Shawn Guo wrote:

> Function regulator_register_fixed() is only meant for registering
> fixed dummy regulators.  Rename it to regulator_register_fixed_dummy()
> for the explicit meaning, so that people do not attempt to register
> those real fixed regulators with this function.

There's no harm in using it for regulators that physically exist if
nothing cares about any of the information it can't provide and renaming
it now is going to cause annoyance with cross tree issues so I'm kind of
reluctant to apply this.  Are there any concrete problems that have been
caused by this or was it just something you noticed when looking at
using it yourself?

> It also removes the kernel doc for @name which is not a parameter for
> the function at all.

This is already done, I can't remember who sent the patch off the top of
my head.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120331/7aa5e044/attachment-0001.sig>

  reply	other threads:[~2012-03-31 10:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-31  8:33 [PATCH 1/2] regulator: fix sysfs name collision between dummy and fixed dummy regulator Shawn Guo
2012-03-31  8:33 ` [PATCH 2/2] regulator: rename function regulator_register_fixed Shawn Guo
2012-03-31 10:25   ` Mark Brown [this message]
2012-03-31 12:54     ` Shawn Guo
2012-03-31 13:45       ` Mark Brown
2012-03-31 10:25 ` [PATCH 1/2] regulator: fix sysfs name collision between dummy and fixed dummy regulator Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120331102507.GB3163@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).