From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH/RFC v2] ARM: amba: Remove AMBA level regulator support
Date: Sun, 1 Apr 2012 22:27:50 +0100 [thread overview]
Message-ID: <20120401212750.GE8971@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CACRpkdYRStgKo_e-4kZKA-V-OoMiV21jRS3R4g1Cq+4c+4=iQA@mail.gmail.com>
On Sun, Apr 01, 2012 at 09:22:50PM +0200, Linus Walleij wrote:
> Combined with the PL022 patch this causes a power regression since
> the PL022 is hereafter always on.
I guess this code isn't in mainline, though? In that case you can
always add a revert of this commit to your out of tree patches if you
need to.
> But I guess if I fix a power domain patch to accomplish much the
> same things then nothing is really lost...
Let me know if you run into any trouble with that - I don't have any
systems which could usefully use such support so I'm unlikely to work on
it directly and from what you were saying you'll need to integrate with
existing power domain code anyway.
> And I do like the change, if for nothing else so for the fact that it
> eventually pushes to power domains what belongs there, so:
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
Thanks.
> But to the defence: power domain code was not in the kernel
> when the AMBA "vcore" regulator was introduced so how else
> could we do it... except for inventing power domains...
Which might've happened sooner if we'd noticed :) There were some other
platforms doing similar things but they mostly used the clock API since
it was always entirely platform code until 3.4 so they're less intrusive
into the generic code.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120401/f1b48146/attachment.sig>
next prev parent reply other threads:[~2012-04-01 21:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-01 18:58 [PATCH/RFC v2] ARM: amba: Remove AMBA level regulator support Mark Brown
2012-04-01 19:22 ` Linus Walleij
2012-04-01 19:39 ` Rabin Vincent
2012-04-01 22:39 ` Linus Walleij
2012-04-02 10:14 ` Mark Brown
2012-04-02 10:43 ` Russell King - ARM Linux
2012-04-02 11:34 ` Mark Brown
2012-04-02 16:57 ` Russell King - ARM Linux
2012-04-02 17:19 ` Mark Brown
2012-04-02 15:52 ` Linus Walleij
2012-04-01 21:27 ` Mark Brown [this message]
2012-04-01 22:33 ` Linus Walleij
2012-04-02 10:41 ` Mark Brown
2012-04-06 7:49 ` Shawn Guo
2012-04-10 8:31 ` Russell King - ARM Linux
2012-04-10 8:35 ` Mark Brown
2012-04-10 8:47 ` Russell King - ARM Linux
2012-04-10 8:58 ` Shawn Guo
2012-04-06 18:12 ` Rob Herring
2012-04-13 9:03 ` Ulf Hansson
2012-04-13 9:18 ` Mark Brown
2012-04-13 9:54 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120401212750.GE8971@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).