From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: fix __io macro for PCMCIA
Date: Wed, 4 Apr 2012 15:23:16 +0100 [thread overview]
Message-ID: <20120404142316.GY24211@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1333509112-1555-1-git-send-email-robherring2@gmail.com>
On Tue, Apr 03, 2012 at 10:11:52PM -0500, Rob Herring wrote:
> @@ -134,9 +136,9 @@ static inline void __iomem *__typesafe_io(unsigned long addr)
> * readb() et.al. on such platforms.
> */
> #ifndef IO_SPACE_LIMIT
> -#if defined(CONFIG_PCMCIA_SOC_COMMON) || defined(CONFIG_PCMCIA_SOC_COMMON_MODULE)
> +#if defined(CONFIG_PCCARD)
> #define IO_SPACE_LIMIT ((resource_size_t)0xffffffff)
> -#elif defined(CONFIG_PCI) || defined(CONFIG_ISA) || defined(CONFIG_PCCARD)
> +#elif defined(CONFIG_PCI) || defined(CONFIG_ISA)
> #define IO_SPACE_LIMIT ((resource_size_t)0xffff)
> #else
> #define IO_SPACE_LIMIT ((resource_size_t)0)
Now that we have a better understanding of the PCMCIA implementation on
HX4700, I'm NAKing at least the above part on the grounds its totally
wrong and bogus - the original unpatched is correct, and the modified
version is likely to introduce further problems for platforms which do
things properly.
next prev parent reply other threads:[~2012-04-04 14:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 3:11 [PATCH] ARM: fix __io macro for PCMCIA Rob Herring
2012-04-04 7:55 ` Arnd Bergmann
2012-04-04 9:03 ` Russell King - ARM Linux
2012-04-04 10:27 ` Arnd Bergmann
2012-04-04 12:56 ` Russell King - ARM Linux
2012-04-04 13:04 ` Russell King - ARM Linux
2012-04-04 13:47 ` Rob Herring
2012-04-04 14:16 ` Russell King - ARM Linux
2012-04-04 10:02 ` Joachim Eastwood
2012-04-04 12:45 ` Rob Herring
2012-04-04 12:49 ` Joachim Eastwood
2012-04-04 11:05 ` Paul Parsons
2012-04-04 14:23 ` Russell King - ARM Linux [this message]
2012-04-04 22:48 ` [PATCH v2] " Rob Herring
2012-04-04 23:03 ` Paul Parsons
2012-04-05 0:47 ` Tony Lindgren
2012-04-05 10:10 ` Joachim Eastwood
2012-04-05 18:29 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120404142316.GY24211@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).