linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH] ARM :OMAP2+: UART: Remove some of uart default pads
Date: Fri, 6 Apr 2012 11:15:57 -0700	[thread overview]
Message-ID: <20120406181556.GC15734@atomide.com> (raw)
In-Reply-To: <CAMrsUdJEY2o2CWjzSg5dabVEkpk48O5njtDU55Z3Jq2vViNJgQ@mail.gmail.com>

* Raja, Govindraj <govindraj.raja@ti.com> [120405 23:08]:
> On Thu, Apr 5, 2012 at 10:28 PM, Tony Lindgren <tony@atomide.com> wrote:
> >
> > Hmm I don't think any muxing was done automatically unless
> > omap_serial_init_port was being called with pins.
> 
> Muxing was happening even if we don't call omap_serial_init_port
> rx pin was muxed for wakeup capability for all uart pins

OK, but that was only for the wake-up muxing? That sounds risky
too for some boards as the board may be using alternative uart
pins instead of the default ones.
 
> omap_uart_idle_init => was populating padconf offset value for ech uart
> which was used in omap_uart_enable/disable_wakeup functions.
> This mechanism was keeping PM happening for all boards.

OK, that's safe if we also bail out for the cases where the default
uart pins are not muxed to serial functionality to start with.

So to summarize, the right fix is to:

1. Only do muxing of uarts from other modes to uart mode if
   omap_serial_init_port is being called with the board specific
   mux options for the port in question.

2. Bail out early in omap_serial_init for each port that does not
   have it's default uart pins already muxed to uart functionality.

3. For the uart ports configured in #1 or #2 above, allow dynamic
   remuxing of the wake-up capability but don't touch the others.

Regards,

Tony

  reply	other threads:[~2012-04-06 18:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-21 10:02 [RESEND PATCH] ARM :OMAP2+: UART: Remove some of uart default pads Govindraj.R
2012-04-03 18:19 ` Tony Lindgren
2012-04-04  6:14   ` Raja, Govindraj
2012-04-05 16:58     ` Tony Lindgren
2012-04-05 17:02       ` Tony Lindgren
2012-04-06  6:05       ` Raja, Govindraj
2012-04-06 18:15         ` Tony Lindgren [this message]
2012-04-09 11:08           ` Raja, Govindraj
2012-04-09 16:56             ` Russ Dill
2012-04-09 20:36               ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120406181556.GC15734@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).