From mboxrd@z Thu Jan 1 00:00:00 1970 From: grant.likely@secretlab.ca (Grant Likely) Date: Fri, 06 Apr 2012 20:45:30 -0700 Subject: [PATCH] gpio: Fix range check in of_gpio_simple_xlate() In-Reply-To: <1333497778-26925-1-git-send-email-stigge@antcom.de> References: <1333497778-26925-1-git-send-email-stigge@antcom.de> Message-ID: <20120407034530.373A13E23DE@localhost> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 4 Apr 2012 02:02:58 +0200, Roland Stigge wrote: > This patch fixes a range check in of_gpio_simple_xlate() by replacing a > "> gc->ngpio" with ">= gc->ngpio" since range is from 0 to gc->ngpio - 1 > > Signed-off-by: Roland Stigge Applied, thanks. g. > > --- > > Applies to v3.4-rc1 > > drivers/of/gpio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-2.6.orig/drivers/of/gpio.c > +++ linux-2.6/drivers/of/gpio.c > @@ -140,7 +140,7 @@ int of_gpio_simple_xlate(struct gpio_chi > if (WARN_ON(gpiospec->args_count < gc->of_gpio_n_cells)) > return -EINVAL; > > - if (gpiospec->args[0] > gc->ngpio) > + if (gpiospec->args[0] >= gc->ngpio) > return -EINVAL; > > if (flags) -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies,Ltd.