From: domenico.andreoli@tomtom.com (Domenico Andreoli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: fix amba_get_enable_vcore()'s handling of probe deferral
Date: Tue, 10 Apr 2012 10:48:33 +0200 [thread overview]
Message-ID: <20120410084833.GA13120@glitch> (raw)
From: Domenico Andreoli <domenico.andreoli@linux.com>
With v3.4-rc1 my board's console started to have problems. earlyprintk
revealed that the PL011 serial driver deferred the initialization and
never attempted it again. This resulted in console not being bound to
any physical device.
The error in probing the serial was due to amba_get_enable_vcore()
not ignoring the -EPROBE_DEFER got from regulator_get(), which has
been recently updated to ask for probe deferral in case the regulator
is not available (yet).
This fix makes amba_get_enable_vcore() consistently handle the new
-EPROBE_DEFER error case.
Signed-off-by: Domenico Andreoli <domenico.andreoli@linux.com>
---
drivers/amba/bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: b/drivers/amba/bus.c
===================================================================
--- a/drivers/amba/bus.c
+++ b/drivers/amba/bus.c
@@ -363,7 +363,7 @@ static int amba_get_enable_vcore(struct
if (IS_ERR(vcore)) {
/* It is OK not to supply a vcore regulator */
- if (PTR_ERR(vcore) == -ENODEV)
+ if (PTR_ERR(vcore) == -EPROBE_DEFER)
return 0;
return PTR_ERR(vcore);
}
next reply other threads:[~2012-04-10 8:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 8:48 Domenico Andreoli [this message]
2012-04-10 9:09 ` [PATCH] ARM: fix amba_get_enable_vcore()'s handling of probe deferral Mark Brown
2012-04-10 9:13 ` Domenico Andreoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120410084833.GA13120@glitch \
--to=domenico.andreoli@tomtom.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).