linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: linux-next: "amba: Remove AMBA level regulator support" commit.
Date: Fri, 13 Apr 2012 11:32:07 +0100	[thread overview]
Message-ID: <20120413103207.GL24211@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CAAQ0ZWReL=+bm9UOnt2=Dfy0zeWbJe3=y3pPzUKRzm2y277kFQ@mail.gmail.com>

On Fri, Apr 13, 2012 at 10:01:52AM +0800, Shawn Guo wrote:
> On 13 April 2012 09:22, Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
> > Hi Mark,
> >
> > The commit in linux-next:
> >
> > -----------------
> > commit b2bc9e0ee349db84035d8141e85babc7986594d7
> > Author: Mark Brown <broonie@sirena.org.uk>
> > Date: ? Mon Apr 2 12:30:35 2012 +0100
> >
> > ? ?ARM: 7366/1: amba: Remove AMBA level regulator support
> > -----------------
> >
> > is pointed at by git bisect for the u8500_defconfig build failure:
> >
> > drivers/dma/ste_dma40.c:2708:3: error: implicit declaration of function
> > 'regulator_disable' [-Werror=implicit-function-declaration]
> > drivers/dma/ste_dma40.c:2747:3: error: implicit declaration of function
> > 'regulator_enable' [-Werror=implicit-function-declaration]
> > drivers/dma/ste_dma40.c:3260:3: error: implicit declaration of function
> > 'regulator_get' [-Werror=implicit-function-declaration]
> > drivers/dma/ste_dma40.c:3271:4: error: implicit declaration of function
> > 'regulator_put' [-Werror=implicit-function-declaration]
> >
> That's because Mark's patch removes "#include
> <linux/regulator/consumer.h>" included indirectly by
> drivers/dma/ste_dma40.c from linux/amba/bus.h.  The ste_dma40.c should
> really directly includes consumer.h.

Okay, I'll drop this patch because it's causing regressions, so it can't
be pushed as a 'fix' during -rc.

  reply	other threads:[~2012-04-13 10:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-13  1:22 linux-next: "amba: Remove AMBA level regulator support" commit Paul Gortmaker
2012-04-13  2:01 ` Shawn Guo
2012-04-13 10:32   ` Russell King - ARM Linux [this message]
2012-04-13 10:44     ` Mark Brown
2012-04-13 10:49       ` Russell King - ARM Linux
2012-04-13 11:25         ` Mark Brown
2012-04-13 12:17           ` Fabio Estevam
2012-04-13 12:07         ` Mark Brown
2012-04-13 12:19           ` Russell King - ARM Linux
2012-04-13 14:04             ` Mark Brown
2012-04-13 12:30     ` Linus Walleij
2012-04-13  8:37 ` Mark Brown
2012-04-13 12:26 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120413103207.GL24211@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).