linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: linux-next: "amba: Remove AMBA level regulator support" commit.
Date: Fri, 13 Apr 2012 11:44:52 +0100	[thread overview]
Message-ID: <20120413104452.GR3168@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120413103207.GL24211@n2100.arm.linux.org.uk>

On Fri, Apr 13, 2012 at 11:32:07AM +0100, Russell King - ARM Linux wrote:
> On Fri, Apr 13, 2012 at 10:01:52AM +0800, Shawn Guo wrote:

> > That's because Mark's patch removes "#include
> > <linux/regulator/consumer.h>" included indirectly by
> > drivers/dma/ste_dma40.c from linux/amba/bus.h.  The ste_dma40.c should
> > really directly includes consumer.h.

> Okay, I'll drop this patch because it's causing regressions, so it can't
> be pushed as a 'fix' during -rc.

I did say we should've been pushing Shawn's patch in as a minimal fix
for 3.4...  Alternatively if you're happy with the code just keeping the
header in place should avoid any issues, the one regression was just an
implicit header dependency.

Regardless of what happens for 3.4 we should keep the removal for -next,
it's clear that we don't want the bus doing this and it's causing
breakage for the non-ST platforms.  Do I need to resend the patch to the
patch system or will the existing copy be OK?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120413/34135552/attachment.sig>

  reply	other threads:[~2012-04-13 10:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-13  1:22 linux-next: "amba: Remove AMBA level regulator support" commit Paul Gortmaker
2012-04-13  2:01 ` Shawn Guo
2012-04-13 10:32   ` Russell King - ARM Linux
2012-04-13 10:44     ` Mark Brown [this message]
2012-04-13 10:49       ` Russell King - ARM Linux
2012-04-13 11:25         ` Mark Brown
2012-04-13 12:17           ` Fabio Estevam
2012-04-13 12:07         ` Mark Brown
2012-04-13 12:19           ` Russell King - ARM Linux
2012-04-13 14:04             ` Mark Brown
2012-04-13 12:30     ` Linus Walleij
2012-04-13  8:37 ` Mark Brown
2012-04-13 12:26 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120413104452.GR3168@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).