linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] pinctrl: pinctrl-imx: add imx pinctrl core driver
Date: Sun, 15 Apr 2012 16:45:49 +0200	[thread overview]
Message-ID: <20120415144549.GJ3852@pengutronix.de> (raw)
In-Reply-To: <20120415141736.GG24997@S2101-09.ap.freescale.net>

On Sun, Apr 15, 2012 at 10:17:43PM +0800, Shawn Guo wrote:
> On Sun, Apr 15, 2012 at 11:49:04AM +0800, Dong Aisheng wrote:
> ...
> > My plan is:
> > 1) not all combinations, just define frequently used ones since
> > it's hard to define all combinations groups for per based IMX.
> > (maybe we can try to add a fix-up function which can do minor changes
> > based on available ones, then user does not need to write a new group
> > caused by only a small change.
> > what do you think?)
> > 
> > 2)  When dt supports macro, will try convert string to integer macro.
> > Then it maybe:
> > fsl,pins = <MX6Q_PAD_SD4_CMD 0
> >                 MX6Q_PAD_SD4_CLK 0
> >                 MX6Q_PAD_SD4_DAT0 1
> >                 .................>,
> > Why i did not start pin id with a raw integer is because it's less
> > meaning to user and
> > not easy to read in dts file.
> > 
> We may want to use integer from the beginning to reduce the churn on
> driver later.
> 
> I'm thinking about documenting the definition we used to have in
> iomux-mx*.h in the binding document and assign id to each of them
> in order.
> 
> pinmux						id
> ------						--
> MX6Q_PAD_SD2_DAT1__USDHC2_DAT1			0
> MX6Q_PAD_SD2_DAT1__ECSPI5_SS0			1
> MX6Q_PAD_SD2_DAT1__WEIM_WEIM_CS_2		2
> ...
> 
> The ordering between the list and imx6q_pin_regs[] array need to match.
> 
> By looking at the binding document, we can just put pinmux-id into
> property "fsl,pins" (maybe rename it to "fsl,pinmux-ids") to get the
> desired pinmux settings.  With doing so, we can gain the following.
> 
> 1) The pinmux-id can be used as index to locate the entry in array
>    imx6q_pin_regs[], so that the slow string lookup can be avoid.
> 
> 2) Property "fsl,mux" can be dropped, as it's been encoded in
>    imx6q_pin_regs[] entry.
> 
> 3) Converting the existing board files to device tree will be much
>    easier.  We only need to find the pinmux-id of those existing
>    definitions and put them in "fsl, pinmux-ids".
> 
> 4) When DTC support macro, we can simply move the pinmux-id list from
>    binding document into dts file.  No driver change is needed at all.
> 
> Thoughts?

I like it. I think it will feel much more natural to use.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2012-04-15 14:45 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-13 16:18 [PATCH 1/3] pinctrl: pinctrl-imx: add imx pinctrl core driver Dong Aisheng
2012-04-13 16:18 ` [PATCH 3/3] ARM: imx6q: switch to use pinctrl driver Dong Aisheng
2012-04-14 13:53   ` Sascha Hauer
2012-04-15  4:03     ` Dong Aisheng
2012-04-15  7:37       ` Shawn Guo
2012-04-16  3:35         ` Dong Aisheng
2012-04-20  1:08           ` Jean-Christophe PLAGNIOL-VILLARD
2012-04-24  8:23           ` Linus Walleij
2012-04-24  8:46             ` Dong Aisheng
2012-04-17 20:23   ` Stephen Warren
2012-04-13 18:17 ` [PATCH 1/3] pinctrl: pinctrl-imx: add imx pinctrl core driver Dong Aisheng
2012-04-14 13:48 ` Sascha Hauer
2012-04-15  3:49   ` Dong Aisheng
2012-04-15 14:17     ` Shawn Guo
2012-04-15 14:45       ` Sascha Hauer [this message]
2012-04-15 17:29       ` Sascha Hauer
2012-04-16  1:47         ` Shawn Guo
2012-04-16 18:01           ` Stephen Warren
2012-04-16  3:47       ` Dong Aisheng
2012-04-16  3:46         ` Shawn Guo
2012-04-17  9:57           ` Dong Aisheng
2012-04-17 12:30             ` Sascha Hauer
2012-04-18  3:38               ` Dong Aisheng
     [not found] ` <1334333915-1174-2-git-send-email-b29396@freescale.com>
2012-04-17 20:12   ` [PATCH 2/3] pinctrl: pinctrl-imx: add imx6q pinctrl driver Stephen Warren
2012-04-18  3:40     ` Dong Aisheng
2012-04-17 20:58 ` [PATCH 1/3] pinctrl: pinctrl-imx: add imx pinctrl core driver Stephen Warren
2012-04-18  7:19   ` Dong Aisheng
2012-04-18 18:06     ` Stephen Warren
2012-04-19 15:28 ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120415144549.GJ3852@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).