linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] CLKDEV: Add helper routines to allocate and add clkdevs for given struct clk *
Date: Mon, 16 Apr 2012 12:02:54 +0100	[thread overview]
Message-ID: <20120416110254.GV24211@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20120416105648.GA414@glitch>

On Mon, Apr 16, 2012 at 12:56:48PM +0200, Domenico Andreoli wrote:
> > I don't think these checks actually help anyone, especially if the user
> > forgets to check the return value (which makes them silent errors.)
> > 
> > If you're going to abuse the interface by passing a NULL clk_lookup or
> > num=0 then you deserve to get a big fat oops to tell you that you messed
> > up.  Same for NULL dev_id and con_id above.
> 
> I hope for a BUG_ON then.

Would you also like all the standard functions such as strcpy() to also
check for NULL pointers just in case you want it to copy your string to
the NULL pointer as well?

This is utterly rediculous.  If your programming ability is soo poor that
you need this kind of help (because you think you might abuse interfaces
by doing really stupid stuff like passing NULL clk_lookup pointers to
functions which can only ever take a valid pointer) then you shouldn't be
touching the kernel.

  parent reply	other threads:[~2012-04-16 11:02 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-16  5:19 [PATCH] CLKDEV: Add helper routines to allocate and add clkdevs for given struct clk * Viresh Kumar
2012-04-16 10:25 ` Domenico Andreoli
2012-04-16 10:30   ` Viresh Kumar
2012-04-16 10:38     ` Russell King - ARM Linux
2012-04-16 10:39       ` Viresh Kumar
2012-04-16 10:56       ` Domenico Andreoli
2012-04-16 10:58         ` Viresh Kumar
2012-04-16 11:02         ` Russell King - ARM Linux [this message]
2012-04-16 11:52           ` Domenico Andreoli
2012-04-16 13:39       ` viresh kumar
2012-04-16 20:46         ` Domenico Andreoli
2012-04-16 20:51           ` s.hauer at pengutronix.de
2012-04-17  3:39             ` Viresh Kumar
2012-04-17  3:48             ` [PATCH V3] " Viresh Kumar
2012-04-17  3:34           ` [PATCH] " Viresh Kumar
2012-04-16 20:56         ` s.hauer at pengutronix.de
2012-04-16 21:06           ` Domenico Andreoli
2012-04-16 21:12             ` s.hauer at pengutronix.de
2012-04-17  3:40               ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120416110254.GV24211@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).