From: sameo@linux.intel.com (Samuel Ortiz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Fix asic3 build error
Date: Mon, 16 Apr 2012 21:11:41 +0200 [thread overview]
Message-ID: <20120416191141.GY24130@sortiz-mobl> (raw)
In-Reply-To: <20120414085709.GQ24211@n2100.arm.linux.org.uk>
Hi Russell,
On Sat, Apr 14, 2012 at 09:57:09AM +0100, Russell King - ARM Linux wrote:
> OMAP randconfig builds occasionally fail with:
>
> drivers/mfd/asic3.c: In function 'asic3_gpio_to_irq':
> drivers/mfd/asic3.c:530: error: 'IRQ_BOARD_START' undeclared (first use in this function)
> drivers/mfd/asic3.c:530: error: (Each undeclared identifier is reported only once
> drivers/mfd/asic3.c:530: error: for each function it appears in.)
>
> Fix it by using asic->irq_base rather than assuming this value is
> IRQ_BOARD_START.
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Dmitry Artamonow sent the same fix a few days ago and it's now part of my
for-linus branch.
> ---
> I don't have the ability to do anything but compile test this. Please
> check that it's correct. Also, I believe that the check for ASIC3_NUM_GPIOS
> is unnecessary - gpiolib won't call your driver if you don't own the GPIO.
Yes, you're right. __gpio_to_irq() call gpio_to_chip(), so I should only
receive requests for GPIOs I own. I'll fix that up as well.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2012-04-16 19:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-14 8:57 [PATCH] Fix asic3 build error Russell King - ARM Linux
2012-04-16 19:11 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120416191141.GY24130@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox