linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: cavokz@gmail.com (Domenico Andreoli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] CLKDEV: Add helper routines to allocate and add clkdevs for given struct clk *
Date: Mon, 16 Apr 2012 23:06:18 +0200	[thread overview]
Message-ID: <20120416210617.GA22932@glitch> (raw)
In-Reply-To: <20120416205655.GJ20478@pengutronix.de>

On Mon, Apr 16, 2012 at 10:56:55PM +0200, s.hauer at pengutronix.de wrote:
> On Mon, Apr 16, 2012 at 07:09:32PM +0530, viresh kumar wrote:
> > On 4/16/12, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
> > > Checking for NULL clk (or IS_ERR(clk)) and returning -ENOMEM does make
> > > sense as I mentioned in my original proposal (it allows you to pass the
> > > returned value from clk_register() directly to this function without
> > > further checking, and you get the right error code.
> > 
> > V2:
> > 
> > From: Russell King <rmk+kernel@arm.linux.org.uk>
> > CLKDEV: Add helper routines to allocate and add clkdevs for given struct clk *
> > 
> > With common clock framework, clks are allocated at runtime. Some of them require
> > clkdevs to be allocated and added in global clkdev list.
> > 
> > This patch introduces helper routines to:
> > 
> >  - allocate and add single clkdev for a single clk structure.
> >  - add multiple clkdevs for a single clk structure.
> > 
> > +
> > +int clk_register_single_clkdev(struct clk *clk, const char *con_id,
> > +		const char *dev_fmt, ...)
> 
> Can we drop the 'single' in the name? Otherwise it's quite a long
> function name. I think name clk_register_clkdev makes it clear already
> that we only register a single clkdev.

clkdev_register?

Dome

  reply	other threads:[~2012-04-16 21:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-16  5:19 [PATCH] CLKDEV: Add helper routines to allocate and add clkdevs for given struct clk * Viresh Kumar
2012-04-16 10:25 ` Domenico Andreoli
2012-04-16 10:30   ` Viresh Kumar
2012-04-16 10:38     ` Russell King - ARM Linux
2012-04-16 10:39       ` Viresh Kumar
2012-04-16 10:56       ` Domenico Andreoli
2012-04-16 10:58         ` Viresh Kumar
2012-04-16 11:02         ` Russell King - ARM Linux
2012-04-16 11:52           ` Domenico Andreoli
2012-04-16 13:39       ` viresh kumar
2012-04-16 20:46         ` Domenico Andreoli
2012-04-16 20:51           ` s.hauer at pengutronix.de
2012-04-17  3:39             ` Viresh Kumar
2012-04-17  3:48             ` [PATCH V3] " Viresh Kumar
2012-04-17  3:34           ` [PATCH] " Viresh Kumar
2012-04-16 20:56         ` s.hauer at pengutronix.de
2012-04-16 21:06           ` Domenico Andreoli [this message]
2012-04-16 21:12             ` s.hauer at pengutronix.de
2012-04-17  3:40               ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120416210617.GA22932@glitch \
    --to=cavokz@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).