linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] pinctrl: pinctrl-imx: add imx pinctrl core driver
Date: Tue, 17 Apr 2012 14:30:06 +0200	[thread overview]
Message-ID: <20120417123006.GC3852@pengutronix.de> (raw)
In-Reply-To: <20120417095722.GF17173@shlinux2.ap.freescale.net>

On Tue, Apr 17, 2012 at 05:57:23PM +0800, Dong Aisheng wrote:
> Sascha & Shawn,
> 
> Just let you know:
> After changes the pinctrl table may look like:
> (i also removed fsl,* config properties since it was introduced for better
> readability before, but after dtc macro support is available, it could also
> be removed. So i removed now. Then the using is much similar as iomux-v3).
> 
> iomuxc at 020e0000 {
>         compatible = "fsl,imx6q-iomuxc";
>         reg = <0x020e0000 0x4000>;
> 
>         /* shared pinctrl settings */
>         uart4 {
>                 pinctrl_uart4_1: uart4grp-1 {
>                         fsl,pins = <58 61>;
>                         fsl,configs = <0x12407>

Why do we have a hex value for the config now? This should be
independent on how we describe the mux settings.

Also I think a single fsl,configs entry for a pin group is not
enough, what for example with I2C where the data line needs a pullup
whereas the clock line does not?

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2012-04-17 12:30 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-13 16:18 [PATCH 1/3] pinctrl: pinctrl-imx: add imx pinctrl core driver Dong Aisheng
2012-04-13 16:18 ` [PATCH 3/3] ARM: imx6q: switch to use pinctrl driver Dong Aisheng
2012-04-14 13:53   ` Sascha Hauer
2012-04-15  4:03     ` Dong Aisheng
2012-04-15  7:37       ` Shawn Guo
2012-04-16  3:35         ` Dong Aisheng
2012-04-20  1:08           ` Jean-Christophe PLAGNIOL-VILLARD
2012-04-24  8:23           ` Linus Walleij
2012-04-24  8:46             ` Dong Aisheng
2012-04-17 20:23   ` Stephen Warren
2012-04-13 18:17 ` [PATCH 1/3] pinctrl: pinctrl-imx: add imx pinctrl core driver Dong Aisheng
2012-04-14 13:48 ` Sascha Hauer
2012-04-15  3:49   ` Dong Aisheng
2012-04-15 14:17     ` Shawn Guo
2012-04-15 14:45       ` Sascha Hauer
2012-04-15 17:29       ` Sascha Hauer
2012-04-16  1:47         ` Shawn Guo
2012-04-16 18:01           ` Stephen Warren
2012-04-16  3:47       ` Dong Aisheng
2012-04-16  3:46         ` Shawn Guo
2012-04-17  9:57           ` Dong Aisheng
2012-04-17 12:30             ` Sascha Hauer [this message]
2012-04-18  3:38               ` Dong Aisheng
     [not found] ` <1334333915-1174-2-git-send-email-b29396@freescale.com>
2012-04-17 20:12   ` [PATCH 2/3] pinctrl: pinctrl-imx: add imx6q pinctrl driver Stephen Warren
2012-04-18  3:40     ` Dong Aisheng
2012-04-17 20:58 ` [PATCH 1/3] pinctrl: pinctrl-imx: add imx pinctrl core driver Stephen Warren
2012-04-18  7:19   ` Dong Aisheng
2012-04-18 18:06     ` Stephen Warren
2012-04-19 15:28 ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120417123006.GC3852@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).