From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] clk: wm831x: Add initial WM831x clock driver
Date: Wed, 18 Apr 2012 10:55:56 +0100 [thread overview]
Message-ID: <20120418095556.GY24211@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1334736433-3402-2-git-send-email-broonie@opensource.wolfsonmicro.com>
On Wed, Apr 18, 2012 at 09:07:13AM +0100, Mark Brown wrote:
> +static __devexit int wm831x_clk_remove(struct platform_device *pdev)
> +{
> + struct wm831x_clk *clkdata = dev_get_drvdata(&pdev->dev);
> +
> + clk_unregister(clkdata->clkout_hw.clk);
> + clk_unregister(clkdata->fll_hw.clk);
> + clk_unregister(clkdata->xtal_hw.clk);
And another reason returning error codes from unregister functions is a
bad idea - you've just demonstrated above why that is. You created this
function which returns an error code, but you're not checking it.
next prev parent reply other threads:[~2012-04-18 9:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 8:07 [PATCH 1/2] clk: Provide dummy clk_unregister() Mark Brown
2012-04-18 8:07 ` [PATCH 2/2] clk: wm831x: Add initial WM831x clock driver Mark Brown
2012-04-18 9:55 ` Russell King - ARM Linux [this message]
2012-04-18 9:54 ` [PATCH 1/2] clk: Provide dummy clk_unregister() Russell King - ARM Linux
2012-04-18 10:48 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120418095556.GY24211@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).