From: thierry.reding@avionic-design.de (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] dt: Add general DMA window parser
Date: Wed, 18 Apr 2012 12:26:29 +0200 [thread overview]
Message-ID: <20120418102629.GA14533@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <20120418.131907.2172387798112620167.hdoyu@nvidia.com>
* Hiroshi Doyu wrote:
> + cells = prop ? *(__be32 *)prop : of_n_addr_cells(dn);
I think this needs to be:
cells = prop ? be32_to_cpup(prop) : of_n_addr_cells(dn);
Only casting isn't enough, you need the bytes to be swapped.
> + cells = prop ? *(__be32 *)prop : of_n_size_cells(dn);
Similarly:
cells = prop ? be32_to_cpup(prop) : of_n_size_cells(dn);
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120418/d8de2877/attachment.sig>
next prev parent reply other threads:[~2012-04-18 10:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201204161534.20089.arnd@arndb.de>
[not found] ` <20120418081746.995724e27bdc726049cd4965@nvidia.com>
[not found] ` <20120418054140.GA17506@avionic-0098.adnet.avionic-design.de>
2012-04-18 6:44 ` [PATCH 1/1] arm/dts: Tegra30: Add device tree support for SMMU Hiroshi Doyu
2012-04-18 7:31 ` Arnd Bergmann
2012-04-18 9:18 ` Hiroshi Doyu
2012-04-18 9:26 ` Thierry Reding
2012-04-18 10:19 ` [PATCH 1/1] dt: Add general DMA window parser Hiroshi Doyu
2012-04-18 10:26 ` Thierry Reding [this message]
2012-04-18 10:36 ` Hiroshi Doyu
2012-04-18 10:54 ` Thierry Reding
2012-04-18 11:13 ` Hiroshi Doyu
2012-04-18 17:27 ` Stephen Warren
2012-04-18 19:39 ` Thierry Reding
2012-04-19 12:32 ` Hiroshi Doyu
2012-04-19 12:19 ` Hiroshi Doyu
2012-04-23 11:53 ` [PATCH v2 " Hiroshi Doyu
2012-04-23 18:16 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120418102629.GA14533@avionic-0098.mockup.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox