From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] clk: Provide dummy clk_unregister()
Date: Wed, 18 Apr 2012 11:48:58 +0100 [thread overview]
Message-ID: <20120418104857.GI3021@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120418095435.GX24211@n2100.arm.linux.org.uk>
On Wed, Apr 18, 2012 at 10:54:35AM +0100, Russell King - ARM Linux wrote:
> Don't make unregister calls return values. Think about this situation
> for a moment:
> You call an unregister function in a drivers ->remove function.
> The unregister function fails. However, the reason the ->remove
> function is being called is because the module is being removed.
> You can't stop the module being removed once the process has
> started. What do you do with this error?
> To put it another way, if an unregister function fails, you're buggered.
I absolutely agree, I think this is a stupid pattern for us to have
(generally the return values just get ignored...) but sadly it appears
to be the pattern that we have return values but ignore them probably
because the driver model does this.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120418/a8e2a324/attachment.sig>
prev parent reply other threads:[~2012-04-18 10:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 8:07 [PATCH 1/2] clk: Provide dummy clk_unregister() Mark Brown
2012-04-18 8:07 ` [PATCH 2/2] clk: wm831x: Add initial WM831x clock driver Mark Brown
2012-04-18 9:55 ` Russell King - ARM Linux
2012-04-18 9:54 ` [PATCH 1/2] clk: Provide dummy clk_unregister() Russell King - ARM Linux
2012-04-18 10:48 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120418104857.GI3021@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).