linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] pinctrl: handle dummy state in core
Date: Wed, 18 Apr 2012 16:00:46 +0200	[thread overview]
Message-ID: <20120418140046.GU3852@pengutronix.de> (raw)
In-Reply-To: <CACRpkdZw6iv=PjvvU4s5L8yV6813gCD7t8Vk-S66v-nXPaf+=Q@mail.gmail.com>

On Wed, Apr 18, 2012 at 03:52:23PM +0200, Linus Walleij wrote:
> On Wed, Apr 18, 2012 at 2:28 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> 
> > Currently Dong Aisheng is working on i.MX6, we have i.MX31, i.MX35,
> > i.MX51 and i.MX53 enabled in the same defconfig. Waiting for all
> > machines turn over at once to pinctrl is illusionary. We have to make
> > drivers work with and without pinctrl. We have a bunch of bad choices:
> >
> > - create a dummy pinctrl for all boards which do not have real pinmux
> > ?support
> 
> Viable compromise.
> 
> > - ignore pinctrl_request errors in drivers.
> 
> Ugh. Not good.
> 
> > - generate and return a dummy pinctrl in the core if no real pinctrl is
> > ?found.
> >
> > (replace pinctrl with regulators or clocks, it's the same situation, and
> > it's not only i.MX specific)
> 
> Since we have dummy regulators, we should not break the design
> pattern creating more confusion.
> 
> Stephen can you live with dummy pinctrl handles emitted by the
> core, if explictly enabled by a Kconfig option?

I'd rather not make it a Kconfig option but a runtime option. With a
Kconfig option we can only chose in the defconfigs whether it won't
work on some boards or it will hide pinctrl errors on all other boards.

Create a pinctrl_provide_dummies() functions which boards can call when
they do not have pinctrl support.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2012-04-18 14:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-16 14:24 [PATCH 1/1] pinctrl: handle dummy state in core Dong Aisheng
2012-04-16 16:03 ` Stephen Warren
2012-04-17  3:42   ` Dong Aisheng
2012-04-17 19:53     ` Stephen Warren
2012-04-18 11:31     ` Linus Walleij
2012-04-18 12:28       ` Sascha Hauer
2012-04-18 13:52         ` Linus Walleij
2012-04-18 14:00           ` Sascha Hauer [this message]
2012-04-18 14:38             ` Dong Aisheng
2012-04-19 17:22               ` Linus Walleij
2012-04-18 17:37           ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120418140046.GU3852@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).