From mboxrd@z Thu Jan 1 00:00:00 1970 From: thierry.reding@avionic-design.de (Thierry Reding) Date: Wed, 18 Apr 2012 21:39:45 +0200 Subject: [PATCH 1/1] dt: Add general DMA window parser In-Reply-To: <4F8EF99E.3050709@wwwdotorg.org> References: <201204180731.54064.arnd@arndb.de> <20120418.121824.1894043789811063795.hdoyu@nvidia.com> <20120418092613.GA8632@avionic-0098.mockup.avionic-design.de> <20120418.131907.2172387798112620167.hdoyu@nvidia.com> <4F8EF99E.3050709@wwwdotorg.org> Message-ID: <20120418193945.GA17960@avionic-0098.mockup.avionic-design.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Stephen Warren wrote: > On 04/18/2012 04:19 AM, Hiroshi Doyu wrote: > > > Subject: [PATCH 1/1] dt: Add general DMA window parser > > > > This code was stolen from: > > "arch/microblaze/kernel/prom_parse.c" > > "arch/powerpc/kernel/prom_parse.c" > > > > Once "ibm," prefix is removed from dts file. This generic one could > > replace the originals. > > > +extern void of_parse_dma_window(struct device_node *dn, > > + const void *dma_window_prop, unsigned long *busno, > > + unsigned long *phys, unsigned long *size); > > At least some other of_*() parsing functions take the property name > rather than the property pointer, and also take an index into the > property in order to support multiple entries in it. See for example > of_parse_phandle and of_get_named_gpio_flags. Should this new API be > similar? E.g.: > > extern void of_parse_dma_window(struct device_node *np, > const char *propname, int index, > unsigned long *busno, > unsigned long *phys, unsigned long *size); In that case the function should return int for proper error handling. Thierry -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 198 bytes Desc: not available URL: