From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] Ethernut 5 board support
Date: Thu, 19 Apr 2012 11:32:01 +0000 [thread overview]
Message-ID: <201204191132.02009.arnd@arndb.de> (raw)
In-Reply-To: <4F8FE598.5090409@egnite.de>
On Thursday 19 April 2012, Tim Schendekehl wrote:
> + i2c at 0 {
> + status = "okay";
> +
> + pcf8563 at 50 {
> + compatible = "pcf8563";
> + reg = <0x51>;
> + };
> +
> + pmmc at 22 {
> + compatible = "pmmc";
> + reg = <0x22>;
> + };
> + };
Please make the compatible properties more specific. The first one should be
compatible="nxp,pcf8563". For the second one, it's not clear what this
refers to. What is a pmmc?
Everything else looks good to me.
Arnd
prev parent reply other threads:[~2012-04-19 11:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-19 10:14 [PATCH V2] Ethernut 5 board support Tim Schendekehl
2012-04-19 11:32 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204191132.02009.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox