linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: plagnioj@jcrosoft.com (Jean-Christophe PLAGNIOL-VILLARD)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] iio: Add device tree support to LPC32xx ADC
Date: Sat, 21 Apr 2012 05:42:04 +0200	[thread overview]
Message-ID: <20120421034204.GA9142@game.jcrosoft.org> (raw)
In-Reply-To: <1334951307-1269-1-git-send-email-stigge@antcom.de>

On 21:48 Fri 20 Apr     , Roland Stigge wrote:
> This patch adds device tree support to the LPC32xx's ADC.
> 
> Signed-off-by: Roland Stigge <stigge@antcom.de>
> 
> ---
> 
> Applies to v3.4-rc3
> 
> Changes since v3:
> * Changed "compatible" strings to non-wildcard versions
> 
> Thanks to Arnd Bergmann and Lars-Peter Clausen for reviewing!
> 
>  Documentation/devicetree/bindings/staging/iio/adc/lpc32xx-adc.txt |   17 ++++++++++
>  drivers/staging/iio/adc/lpc32xx_adc.c                             |   13 +++++++
>  2 files changed, 30 insertions(+)
> 
> --- /dev/null
> +++ linux-2.6/Documentation/devicetree/bindings/staging/iio/adc/lpc32xx-adc.txt
> @@ -0,0 +1,17 @@
> +* NXP LPC32xx SoC ADC controller
> +
> +Required properties:
> +- compatible: must be "nxp,lpc3220-adc", "nxp,lpc3230-adc", "nxp,lpc3240-adc"
> +  or "nxp,lpc3250-adc"
> +- reg: physical base address of the controller and length of memory mapped
> +  region.
> +- interrupts: The ADC interrupt
> +
> +Example:
> +
> +	adc at 40048000 {
> +		compatible = "nxp,lpc3250-adc";
> +		reg = <0x40048000 0x1000>;
> +		interrupt-parent = <&mic>;
> +		interrupts = <39 0>;
> +	};
> --- linux-2.6.orig/drivers/staging/iio/adc/lpc32xx_adc.c
> +++ linux-2.6/drivers/staging/iio/adc/lpc32xx_adc.c
> @@ -30,6 +30,7 @@
>  #include <linux/clk.h>
>  #include <linux/err.h>
>  #include <linux/completion.h>
> +#include <linux/of.h>
>  
>  #include "../iio.h"
>  #include "../sysfs.h"
> @@ -221,12 +222,24 @@ static int __devexit lpc32xx_adc_remove(
>  	return 0;
>  }
>  
> +#ifdef CONFIG_OF
> +static const struct of_device_id lpc32xx_adc_match[] = {
> +	{ .compatible = "nxp,lpc3220-adc" },
> +	{ .compatible = "nxp,lpc3230-adc" },
> +	{ .compatible = "nxp,lpc3240-adc" },
> +	{ .compatible = "nxp,lpc3250-adc" },
do you really need to list them all?


if they are all cmpatible just list the first one

Best Regards,
J.

      reply	other threads:[~2012-04-21  3:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-20 19:48 [PATCH v4] iio: Add device tree support to LPC32xx ADC Roland Stigge
2012-04-21  3:42 ` Jean-Christophe PLAGNIOL-VILLARD [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120421034204.GA9142@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).