From: akpm@linux-foundation.org (Andrew Morton)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drivers/rtc/rtc-m41t93.c: don't let get_time() reset error state
Date: Mon, 23 Apr 2012 13:53:22 -0700 [thread overview]
Message-ID: <20120423135322.5b9b1635.akpm@linux-foundation.org> (raw)
In-Reply-To: <201204231230.q3NCUbbP015327@gatekeeper.vosshq.de>
On Mon, 23 Apr 2012 12:51:23 +0200
Nikolaus Voss <n.voss@weinmann.de> wrote:
> If the rtc reports the time might be invalid due to oscillator
> failure, this flags must not be reset by get_time() as the read
> operation doesn't make the time valid.
>
> Instead, the flag is reset in set_time() when a valid time is
> to be written.
This is rather vague - what is/are "these flags"? From the patch I
think you're referring to (the maddeningly undocumented)
M41T93_FLAG_ST? If so, I'd suggest something like
: If the rtc reports the time might be invalid due to oscillator failure,
: the M41T93_FLAG_ST flag must not be reset by get_time() as the read
: operation doesn't make the time valid.
:
: Instead, the M41T93_FLAG_ST flag is reset in set_time() when a valid time
: is to be written.
Secondly, you provided no description of the user-visible effects of
the bug. Hence I cannot work out which kernel version(s) this patch
should be merged into.
next parent reply other threads:[~2012-04-23 20:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201204231230.q3NCUbbP015327@gatekeeper.vosshq.de>
2012-04-23 20:53 ` Andrew Morton [this message]
2012-04-24 4:51 ` [PATCH] drivers/rtc/rtc-m41t93.c: don't let get_time() reset error state Voss, Nikolaus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120423135322.5b9b1635.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).