From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] staging: tidspbridge: fix build errors for OMAP2_L4_IO_ADDRESS
Date: Mon, 23 Apr 2012 15:39:17 +0100 [thread overview]
Message-ID: <20120423143917.GD24299@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1335191654-1217-1-git-send-email-felipe.contreras@gmail.com>
On Mon, Apr 23, 2012 at 05:34:14PM +0300, Felipe Contreras wrote:
> drivers/staging/tidspbridge/core/tiomap3430.c: In function 'bridge_brd_start':
> drivers/staging/tidspbridge/core/tiomap3430.c:425: error: implicit declaration of function 'OMAP2_L4_IO_ADDRESS'
> drivers/staging/tidspbridge/core/wdt.c: In function 'dsp_wdt_init':
> drivers/staging/tidspbridge/core/wdt.c:56: error: implicit declaration of function 'OMAP2_L4_IO_ADDRESS'
>
> The proper fix will come later.
Hmm. Given that this is staging stuff, which hasn't been making much
progress out of staging, I'd suggest not doing the quick fix on it, but
spending the time to implement the proper fix now and move the code
closer to the point where it can move out of staging. You might get
a gold star from Greg for moving this forward...
next prev parent reply other threads:[~2012-04-23 14:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 14:34 [PATCH] staging: tidspbridge: fix build errors for OMAP2_L4_IO_ADDRESS Felipe Contreras
2012-04-23 14:39 ` Russell King - ARM Linux [this message]
2012-04-23 14:49 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120423143917.GD24299@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox