From: pavel@denx.de (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: Sharing header files -- arch/arm/mach-generic ?
Date: Mon, 23 Apr 2012 21:40:42 +0200 [thread overview]
Message-ID: <20120423194042.GA5734@elf.ucw.cz> (raw)
Hi!
I have new architecture I'd like to merge into the mainline. It has
some code very similar to existing plaforms (for example
real differences to mach-realview/platsmp.c are two lines.)
Is that a problem?
Should mach-generic/platsmp.c be created, so code can be better
shared? Or are the code pieces small enough that this duplication can
be ignored?
headsmp.S is another candidate for sharing. AFAICT we have 4 times
identical code in the tree already:
./mach-exynos/headsmp.S: ldmia r4, {r5, r6}
./plat-versatile/headsmp.S: ldmia r4, {r5, r6}
./mach-ux500/headsmp.S: ldmia r4, {r5, r6}
./mach-msm/headsmp.S: ldmia r4, {r5, r6}
Thoughts?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next reply other threads:[~2012-04-23 19:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 19:40 Pavel Machek [this message]
2012-04-23 19:52 ` Sharing header files -- arch/arm/mach-generic ? Russell King - ARM Linux
2012-04-23 20:15 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120423194042.GA5734@elf.ucw.cz \
--to=pavel@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox