From mboxrd@z Thu Jan 1 00:00:00 1970 From: aisheng.dong@freescale.com (Dong Aisheng) Date: Tue, 24 Apr 2012 22:25:58 +0800 Subject: [PATCH 1/2] pinctrl: add pinctrl-mxs support In-Reply-To: <20120424132648.GF26306@S2101-09.ap.freescale.net> References: <1334823125-24159-1-git-send-email-shawn.guo@linaro.org> <20120421164713.GA3408@das-ThinkPad-X61> <20120422163255.GD26306@S2101-09.ap.freescale.net> <20120423074702.GD24843@shlinux2.ap.freescale.net> <20120423144623.GU26306@S2101-09.ap.freescale.net> <20120424034010.GA32166@shlinux2.ap.freescale.net> <20120424040520.GC26306@S2101-09.ap.freescale.net> <20120424132648.GF26306@S2101-09.ap.freescale.net> Message-ID: <20120424142557.GC24122@shlinux2.ap.freescale.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Apr 24, 2012 at 09:26:51PM +0800, Shawn Guo wrote: > On Tue, Apr 24, 2012 at 03:07:35PM +0200, Linus Walleij wrote: > > Hm, that's pretty interesting - but are imx and mxs even going to use the > > same driver then? Maybe I'm not following - are they similar > > in all other aspects than for this pin config stuff? > > > The mach-mxs (i.MX23 and i.MX28) is a totally different sub-architecture > from mach-imx. Freescale acquired it from SigmaTel a few years back. > These two sub-architectures have completely different pin controllers. > So, no, they are not going to use the same pinctrl driver but two > different ones, pinctrl-mxs and pinctrl-imx. > > The only common aspect is both two controllers only supports pin basis > configuration (no hardware pingroup). I think many other > sub-architectures including omap are same on this aspect. > The key point is not the hw difference, it is if we can find common part on a higher abstract layer, that's what a subsystem or a good designed common driver do, right? My key point is to do common things like dt binding in pinctrl-imx and handle hw difference in each SoC pinctrl driver. Regards Dong Aisheng