From: w.sang@pengutronix.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv8 06/10] I2C: OMAP: Fix the crash in i2c remove
Date: Tue, 24 Apr 2012 20:18:06 +0200 [thread overview]
Message-ID: <20120424181806.GF9007@pengutronix.de> (raw)
In-Reply-To: <4F96ED77.9070503@ti.com>
On Tue, Apr 24, 2012 at 11:44:15PM +0530, Shubhrajyoti wrote:
> On Monday 23 April 2012 10:19 PM, Wolfram Sang wrote:
> >> [ 154.901153] Exception stack(0xdf9b9fb0 to 0xdf9b9ff8)
> >> > [ 154.907104] 9fa0: beaf1f04 4006be00 0000000f 0000000c
> >> > [ 154.915710] 9fc0: 4006c000 00000000 00008034 ffffff40 00000007 00000000 00000000 0007b8d7
> >> > [ 154.916778] 9fe0: 00000000 beaf1b68 0000d23c 4005baf0 80000010 ffffffff
> >> > [ 154.931335] r6:ffffffff r5:80000010 r4:4005baf0 r3:beaf1f04
> >> > [ 154.937316] ---[ end trace 1b75b31a2719ed21 ]--
> >> >
> >> > Cc: <stable@vger.kernel.org>
> >> > Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
> > Is this really the correct solution? I do wonder that every driver using
> > runtime PM should enable the clocks on their own. That should be done by
> > the core,
> By core you don't mean the i2c core but the pm layer right?
Yes.
> > I'd say; it is not unusual that drivers need to write to
> > registers in remove(). If it is correct, can I get some acks?
> I did see the crash.
That was never a doubt. With "correct" I meant "correct solution".
> Will wait for the pm experts to comment.
Yup.
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120424/683e5f8d/attachment.sig>
next prev parent reply other threads:[~2012-04-24 18:18 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-19 13:28 [PATCHv8 00/10] I2C fixes Shubhrajyoti D
2012-04-19 13:28 ` [PATCHv8 01/10] I2C: OMAP: make omap_i2c_unidle/idle functions depend on CONFIG_PM_RUNTIME Shubhrajyoti D
2012-04-19 13:28 ` [PATCHv8 02/10] I2C: OMAP: Fix the mismatch of pm_runtime enable and disable Shubhrajyoti D
2012-04-23 15:43 ` Wolfram Sang
2012-04-23 15:57 ` Datta, Shubhrajyoti
2012-04-19 13:28 ` [PATCHv8 03/10] I2C: OMAP: Fix the interrupt clearing in OMAP4 Shubhrajyoti D
2012-04-19 13:28 ` [PATCHv8 04/10] I2C: OMAP: Fix the error handling Shubhrajyoti D
2012-04-23 17:10 ` Wolfram Sang
2012-04-19 13:28 ` [PATCHv8 05/10] I2C: OMAP: Don't check if wait_for_completion_timeout() returns less than zero Shubhrajyoti D
2012-04-23 17:11 ` Wolfram Sang
2012-04-19 13:28 ` [PATCHv8 06/10] I2C: OMAP: Fix the crash in i2c remove Shubhrajyoti D
2012-04-23 16:49 ` Wolfram Sang
2012-04-24 18:14 ` Shubhrajyoti
2012-04-24 18:18 ` Wolfram Sang [this message]
2012-04-26 6:28 ` Shubhrajyoti
2012-04-26 6:43 ` Shubhrajyoti
2012-04-19 13:28 ` [PATCHv8 07/10] I2C: OMAP: Handle error check for pm runtime Shubhrajyoti D
2012-04-23 16:20 ` Wolfram Sang
2012-04-23 17:26 ` Shubhrajyoti
2012-04-19 13:28 ` [PATCHv8 08/10] I2C: OMAP: fix missing handling of errata I2C_OMAP3_1P153 Shubhrajyoti D
2012-04-23 16:43 ` Wolfram Sang
2012-04-23 17:35 ` Shubhrajyoti
2012-04-19 13:28 ` [PATCHv8 09/10] I2C: OMAP: Do not set the XUDF if the underflow is not reached Shubhrajyoti D
2012-04-23 16:42 ` Wolfram Sang
2012-04-23 17:29 ` Shubhrajyoti
2012-04-19 13:28 ` [PATCHv8 10/10] I2C: OMAP: Rename the 1p153 to the erratum id i462 Shubhrajyoti D
2012-04-23 17:05 ` [PATCHv8 00/10] I2C fixes Wolfram Sang
2012-04-23 17:41 ` Shubhrajyoti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120424181806.GF9007@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).