linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: Use a separate struct for holding init data.
Date: Thu, 26 Apr 2012 10:42:01 +0200	[thread overview]
Message-ID: <20120426084201.GF17184@pengutronix.de> (raw)
In-Reply-To: <4F98EB10.2000505@codeaurora.org>

On Wed, Apr 25, 2012 at 11:28:32PM -0700, Saravana Kannan wrote:
> 
> >diff --git a/drivers/clk/clk-mux.c b/drivers/clk/clk-mux.c
> >index 6e58f11..8e97491 100644
> >--- a/drivers/clk/clk-mux.c
> >+++ b/drivers/clk/clk-mux.c
> >@@ -95,6 +95,7 @@ struct clk *clk_register_mux(struct device *dev, const char *name,
> >  {
> 
> I would really like to remove these functions. At least until we add
> device tree support where each clock is listed in device tree.
> 
> At present, these functions seem to be abused more than actually
> being used appropriately.

I think this goes in my direction. Still exactly this abuse how you call
it makes me relatively independent of for example the changes you
introduce with your patch. Had I static initializers I would now have
to start a rebase orgy.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2012-04-26  8:42 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-26  5:58 [PATCH] clk: Use a separate struct for holding init data Saravana Kannan
2012-04-26  6:28 ` Saravana Kannan
2012-04-26  8:42   ` Sascha Hauer [this message]
2012-04-26  9:36     ` Saravana Kannan
2012-04-26  9:51       ` Sascha Hauer
2012-04-30 19:30         ` Saravana Kannan
2012-04-30 22:19           ` Turquette, Mike
2012-04-30 22:46             ` Saravana Kannan
2012-05-01  8:11               ` Shawn Guo
2012-05-01  9:13                 ` Andrew Lunn
2012-05-01 17:00                   ` Mark Brown
2012-05-01 18:03                     ` Saravana Kannan
2012-05-01 18:19                       ` Mark Brown
2012-05-02  1:56                         ` Mike Turquette
2012-05-02  2:14                           ` Shawn Guo
2012-05-02  5:16                           ` Andrew Lunn
2012-05-02 19:19                             ` Mike Turquette
2012-05-02 13:32                           ` Arnd Bergmann
2012-05-02 15:28                           ` Mark Brown
2012-05-01 18:04                     ` Andrew Lunn
2012-04-26  8:39 ` Sascha Hauer
2012-04-26  9:15   ` Saravana Kannan
2012-04-26  9:49   ` Mark Brown
2012-05-02  2:04 ` Mike Turquette
2012-05-02  4:42   ` Saravana Kannan
2012-05-02 19:07     ` Mike Turquette
2012-05-02  9:58 ` Sascha Hauer
2012-05-02 10:02   ` Russell King - ARM Linux
2012-05-02 10:11     ` Sascha Hauer
2012-05-03 23:03 ` Domenico Andreoli
2012-05-04  1:11   ` Saravana Kannan
2012-05-04  6:50     ` Domenico Andreoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120426084201.GF17184@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).